Skip to content

Adding Orchestrator Software Templates Infra Helm Chart - #170

Merged
openshift-merge-bot[bot] merged 28 commits into
redhat-developer:mainfrom
elai-shalev:orch-software-templates-infra
Jul 10, 2025
Merged

Adding Orchestrator Software Templates Infra Helm Chart#170
openshift-merge-bot[bot] merged 28 commits into
redhat-developer:mainfrom
elai-shalev:orch-software-templates-infra

Conversation

@elai-shalev

@elai-shalev elai-shalev commented Jun 12, 2025

Copy link
Copy Markdown

This PR will add a new Helm Chart to the rhdh-chart repository.
"Orchestrator Software Templates Infra" Helm Chart is responsible for installing Openshift Gitops and Openshift Pipelines operators as part of "post installation" steps for Orchestrator.
This is part of this epic - RHIDP-7592.

This helm chart is installing Cluster-scoped resources, and required Admin privileges to install.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@elai-shalev
elai-shalev requested a review from a team as a code owner June 12, 2025 13:25
@elai-shalev elai-shalev changed the title Adding Orchestrator Software Templates Infra Helm Chart (WIP) Adding Orchestrator Software Templates Infra Helm Chart Jun 12, 2025
@github-actions

Copy link
Copy Markdown

⚠️ Files changed after running the pre-commit hooks

Those changes should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

@elai-shalev

Copy link
Copy Markdown
Author

Hey @rm3l, I believe this PR is ready to be reviewed.
The new chart includes the templates to install Openshift Gitops and Openshift Pipelines on a OCP cluster.
The Chart includes a post-cleanup jobs for both operators.

The current issues with CI:
(1) SonarCloud issue related to RBAC -- The RBAC templates are there, and looks like the job is working. Might be a race condition with the analysis?

(2) Test Charts CI. Currently the CI runs fail on behalf of the non existing "openshift-operators" namespace. That namespace is a default in the values yaml, and it should be changes for the CI values.
-- What do you think is the approach here? Adding the new CI values? skipping this CI job because of the k8s env?

Thanks

@rm3l

rm3l commented Jun 18, 2025

Copy link
Copy Markdown
Member

/cc

@openshift-ci
openshift-ci Bot requested a review from rm3l June 18, 2025 11:37
Comment thread charts/orchestrator-software-templates-infra/Chart.yaml
Comment thread charts/orchestrator-software-templates-infra/docs/GitopsOperator.md Outdated
Comment thread charts/orchestrator-software-templates-infra/docs/GitopsOperator.md Outdated
@rm3l

rm3l commented Jun 19, 2025

Copy link
Copy Markdown
Member

The new chart includes the templates to install Openshift Gitops and Openshift Pipelines on a OCP cluster.
The Chart includes a post-cleanup jobs for both operators.

The current issues with CI:
(1) SonarCloud issue related to RBAC -- The RBAC templates are there, and looks like the job is working. Might be a race condition with the analysis?

Yeah, this reminds me of a similar issue we noticed on a previous PR: #108 (comment)
Again, this seems like a false positive to me. I've dismissed it for now. Let's see how it goes now.

(2) Test Charts CI. Currently the CI runs fail on behalf of the non existing "openshift-operators" namespace. That namespace is a default in the values yaml, and it should be changes for the CI values.
-- What do you think is the approach here? Adding the new CI values? skipping this CI job because of the k8s env?

Would it be possible to use the upstream of the OpenShift Pipelines/GitOps in a CI values file? I can see that they can be installed via OLM as well (argo-cd and tektoncd operators).

Comment thread charts/orchestrator-software-templates-infra/templates/tests/infra-test.yaml Outdated
Comment thread charts/orchestrator-software-templates-infra/templates/tests/infra-test.yaml Outdated
@github-actions

Copy link
Copy Markdown

⚠️ Files changed after running the pre-commit hooks

Those changes should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

@rm3l rm3l closed this Jul 10, 2025
@rm3l rm3l reopened this Jul 10, 2025
@sonarqubecloud

Copy link
Copy Markdown

@elai-shalev elai-shalev changed the title (WIP) Adding Orchestrator Software Templates Infra Helm Chart Adding Orchestrator Software Templates Infra Helm Chart Jul 10, 2025

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 10, 2025
@openshift-merge-bot
openshift-merge-bot Bot merged commit 91a7ed5 into redhat-developer:main Jul 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants