Skip to content

fix: avoid double helm upgrade in CI install script #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 5 commits into from
Jun 26, 2025
Merged

fix: avoid double helm upgrade in CI install script #174

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae97578
fix: avoid double helm upgrade in CI install script
Fortune-Ndlovu Jun 22, 2025
0c16704
handle secret not found
Fortune-Ndlovu Jun 23, 2025
6e5c87b
Merge branch 'main' into fix-rhdh-ci-install-script-helm-upgrade-twice
Fortune-Ndlovu Jun 24, 2025
bf53999
remove code block
Fortune-Ndlovu Jun 25, 2025
a0ee16f
update
Fortune-Ndlovu Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .rhdh/scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,6 @@ EOF
rm -fr /tmp/"$CV"-unpacked
fi

# 1. install (or upgrade)
helm upgrade redhat-developer-hub -i "${CHART_URL}" --version "$CV"

# 2. collect values
PASSWORD=$(kubectl get secret redhat-developer-hub-postgresql -o jsonpath="{.data.password}" | base64 -d)
if [[ $(oc auth can-i get route/openshift-console) == "yes" ]]; then
CLUSTER_ROUTER_BASE=$(oc get route console -n openshift-console -o=jsonpath='{.spec.host}' | sed 's/^[^.]*\.//')
elif [[ -z $CLUSTER_ROUTER_BASE ]]; then
Expand All @@ -148,10 +143,9 @@ elif [[ -z $CLUSTER_ROUTER_BASE ]]; then
exit 1
fi

# 3. change values
# change values
helm upgrade redhat-developer-hub -i "${CHART_URL}" --version "$CV" \
--set global.clusterRouterBase="${CLUSTER_ROUTER_BASE}" \
--set global.postgresql.auth.password="$PASSWORD"
--set global.clusterRouterBase="${CLUSTER_ROUTER_BASE}"

echo "
While deploying you can watch at
Expand Down
Loading