ci: Add CI values file for testing the Orchestrator flavor [RHIDP-7469]

[rm3l]

Description of the change

This PR adds a CI values file in the backstage chart for testing this Chart with the Orchestrator enabled. Since installing the Orchestrator flavor requires the orchestrator-infra chart, and the operators the orchestrator-infra chart installs are only available in the RH CatalogSource, this tries to install the bare minimum requirements (Knative and SonataFlow CRDs) to have a running instance of the app.
The scope of the tests in the backstage chart is not to have complete app E2E tests, but instead to make sure that the chart is installable and the app starts as expected. So this should be fine for having some minimal testing of this. There is a different Story for full E2E orchestrator testing.

Which issue(s) does this PR fix or relate to

Fixes https://issues.redhat.com/browse/RHIDP-7469

How to test changes / Special notes to the reviewer

We can see in the workflow run that the new CI values is being picked in the CI.

Checklist

• For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
• For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
• JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
• Tests pass using the Chart Testing tool and the ct lint command.
• If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Summary by Sourcery

Add CI support for testing the Orchestrator flavor by introducing a dedicated values file, extending the test workflow to detect Backstage chart changes and install required CRDs, and bump the Backstage chart version.

Enhancements:

• Introduce a with-orchestrator-values.yaml file to define minimal configuration for testing the Orchestrator flavor

CI:

• Detect Backstage chart changes in the test workflow and conditionally install Knative and SonataFlow CRDs for Orchestrator tests

Chores:

• Bump Backstage Helm chart version to 4.2.12

[sourcery-ai]

Reviewer's Guide

Adds CI support for the Orchestrator flavor by introducing a dedicated values file and enhancing the GitHub Actions workflow to detect Backstage chart changes and install required CRDs.

Class diagram for new Orchestrator CI values file structure

classDiagram
  class OrchestratorCIValues {
    route: enabled (bool)
    upstream.postgresql.primary.persistence.enabled (bool)
    global.dynamic.plugins (list)
    orchestrator.enabled (bool)
  }
  class Plugin {
    package: string
    disabled: bool
  }
  OrchestratorCIValues "1" -- "*" Plugin : dynamic.plugins

Loading

File-Level Changes

Change	Details	Files
Refactor CI workflow to detect Backstage chart changes and install CRDs	Rename list-changed output variable Add conditional flag when Backstage chart is modified Insert step to apply Knative and SonataFlow CRDs before testing	.github/workflows/test.yaml
Introduce Orchestrator-specific CI values file	Create with-orchestrator-values.yaml under charts/backstage/ci Enable orchestrator feature and disable default route Configure upstream postgresql persistence and dynamic plugins	charts/backstage/ci/with-orchestrator-values.yaml
Bump Backstage chart version and update documentation badge	Increment Chart.yaml version from 4.2.11 to 4.2.12 Update README.md version badge to 4.2.12	charts/backstage/Chart.yaml charts/backstage/README.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sourcery-ai]

Hey @rm3l - I've reviewed your changes - here's some feedback:

• The workflow currently triggers the CRD install step on any Backstage chart change; consider specifically checking for changes to the new ci/with-orchestrator-values.yaml file to avoid unnecessary CRD installs.
• Rather than pulling the SonataFlow operator manifest unpinned, pin it to a specific digest or vendor the CRD files locally to guard against upstream changes breaking the CI.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- The workflow currently triggers the CRD install step on any Backstage chart change; consider specifically checking for changes to the new `ci/with-orchestrator-values.yaml` file to avoid unnecessary CRD installs.
- Rather than pulling the SonataFlow operator manifest unpinned, pin it to a specific digest or vendor the CRD files locally to guard against upstream changes breaking the CI.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rm3l]

This only adds a CI values file, with no impact on the actual chart. Merging to close out https://issues.redhat.com/browse/RHIDP-6159