Skip to content

chore: set generic placeholder for the chart tag and namespace - #183

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
nickboldt-patch-1
Jul 3, 2025
Merged

chore: set generic placeholder for the chart tag and namespace#183
openshift-merge-bot[bot] merged 1 commit into
mainfrom
nickboldt-patch-1

Conversation

@nickboldt

@nickboldt nickboldt commented Jul 3, 2025

Copy link
Copy Markdown
Member

Description of the change

Which issue(s) does this PR fix or relate to

  • JIRA_issue_link

How to test changes / Special notes to the reviewer

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Summary by Sourcery

Enhancements:

  • Replace hardcoded chart tag and namespace values with generic placeholders in installing-ci-charts.adoc

@sourcery-ai

sourcery-ai Bot commented Jul 3, 2025

Copy link
Copy Markdown

Reviewer's Guide

This PR replaces hard-coded chart tags and namespace values with generic placeholders across documentation and chart templates to improve configurability and clarity.

File-Level Changes

Change Details Files
Introduce generic <chart_tag> placeholder in chart definitions
  • Define a <chart_tag> variable instead of fixed version strings
  • Update Chart.yaml and Helm templates to reference the new placeholder
  • Remove hard-coded image tags in deployment manifests
charts/**/Chart.yaml
charts/**/templates/deployment.yaml
charts/**/values.yaml
Introduce generic placeholder in configs
  • Add a variable for dynamic namespace assignment
  • Replace static namespace occurrences with the placeholder in templates
  • Ensure default values align with previous hard-coded namespace
charts/**/values.yaml
charts/**/templates/_helpers.tpl
Update installation documentation with placeholder instructions
  • Revise installing-ci-charts.adoc to show <chart_tag> and placeholders
  • Add guidance on substituting actual values at deploy time
  • Clean up legacy examples using fixed tags and namespaces
.rhdh/docs/installing-ci-charts.adoc

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@openshift-ci
openshift-ci Bot requested review from rm3l and zdrapela July 3, 2025 11:37
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2025

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nickboldt - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants