Skip to content

[release-1.7] fix: Make the orchestrator plugins list configurable in the default values file [RHDHBUGS-1889] (#194) - #196

Merged
rm3l merged 2 commits into
redhat-developer:release-1.7from
rm3l:cherry-pick/release-1.7/rhdhbugs-1889-techdebt-helm-the-orchestrator-plugins-list-should-be-configurable-in-the-default-values-file
Jul 21, 2025
Merged

[release-1.7] fix: Make the orchestrator plugins list configurable in the default values file [RHDHBUGS-1889] (#194)#196
rm3l merged 2 commits into
redhat-developer:release-1.7from
rm3l:cherry-pick/release-1.7/rhdhbugs-1889-techdebt-helm-the-orchestrator-plugins-list-should-be-configurable-in-the-default-values-file

Conversation

@rm3l

@rm3l rm3l commented Jul 21, 2025

Copy link
Copy Markdown
Member

Manual cherry-pick of #194 (comment)

Summary by Sourcery

Enable configurable orchestrator plugins by adding an orchestrator.plugins list to the default values, update templates and documentation to use the new configuration, and bump the chart version to 4.4.2

New Features:

  • Expose orchestrator.plugins in values.yaml to allow customizing the default list of orchestrator plugins

Enhancements:

  • Update dynamic-plugins-configmap template to directly iterate over the new orchestrator.plugins values
  • Remove the unused partials template file

Build:

  • Bump chart version to 4.4.2

Documentation:

  • Update README and values schema to document the orchestrator.plugins configuration

…alues file [RHDHBUGS-1889] (redhat-developer#194)

Co-authored-by: Elai Shalev <129178340+elai-shalev@users.noreply.github.com>
@sourcery-ai

sourcery-ai Bot commented Jul 21, 2025

Copy link
Copy Markdown

Reviewer's Guide

This PR exposes the orchestrator plugins list as a configurable value in the Helm chart, updates the scaffolding to consume that list directly, and bumps the chart version accordingly.

Entity relationship diagram for orchestrator.plugins configuration

erDiagram
    ORCHESTRATOR ||--o{ ORCHESTRATOR_PLUGIN : has
    ORCHESTRATOR_PLUGIN {
        bool disabled
        string package
        string integrity
        object pluginConfig
    }
Loading

Class diagram for the new orchestrator.plugins Helm values structure

classDiagram
    class OrchestratorConfig {
        +bool enabled
        +list plugins
        +bool serverlessLogicOperator.enabled
        +bool serverlessOperator.enabled
        +string sonataflowPlatform.createDBJobImage
    }
    class OrchestratorPlugin {
        +bool disabled
        +string package
        +string integrity
        +object pluginConfig
    }
    OrchestratorConfig "1" o-- "*" OrchestratorPlugin : plugins
Loading

File-Level Changes

Change Details Files
Introduce configurable orchestrator.plugins in default values
  • Added a plugins section under orchestrator in values.yaml with package URLs, integrity hashes, disabled flags, and nested pluginConfig
  • Extended the README values table to document the new orchestrator.plugins field
  • Updated values.schema.json and its template to include validation for the plugins list
charts/backstage/values.yaml
charts/backstage/README.md
charts/backstage/values.schema.json
charts/backstage/values.schema.tmpl.json
Streamline dynamic plugin loading in the ConfigMap template
  • Removed include and fromYaml logic for orchestrator plugins
  • Updated dynamic-plugins-configmap.yaml to range directly over .Values.orchestrator.plugins
charts/backstage/templates/dynamic-plugins-configmap.yaml
Bump chart version to 4.4.2
  • Incremented version in Chart.yaml
  • Updated badge version in README.md
charts/backstage/Chart.yaml
charts/backstage/README.md
Remove obsolete partials template
  • Deleted the unused _partials.tpl file
charts/backstage/templates/_partials.tpl

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@openshift-ci
openshift-ci Bot requested review from gazarenkov and zdrapela July 21, 2025 11:20
Co-authored-by: rm3l <rm3l@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

⚠️ Files changed after running the pre-commit hooks

Those changes should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

@rm3l rm3l closed this Jul 21, 2025
@rm3l rm3l reopened this Jul 21, 2025
@sonarqubecloud

Copy link
Copy Markdown

@rm3l
rm3l enabled auto-merge (squash) July 21, 2025 11:25
@rm3l rm3l added the lgtm label Jul 21, 2025
@rm3l
rm3l merged commit eb4a607 into redhat-developer:release-1.7 Jul 21, 2025
7 of 8 checks passed
@rm3l
rm3l deleted the cherry-pick/release-1.7/rhdhbugs-1889-techdebt-helm-the-orchestrator-plugins-list-should-be-configurable-in-the-default-values-file branch July 21, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant