[release-1.7] fix: Add test case deploying an Orchestrator-flavored instance with a user provided npmrc secret [RHDHBUGS-1893] (#195) - #197
Conversation
… user provided npmrc secret [RHDHBUGS-1893] (redhat-developer#195) Co-authored-by: rm3l <rm3l@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Reviewer's GuideThis PR backports a new test-only option to inject a user-provided npmrc secret into an Orchestrator-flavored Backstage deployment, bumps the chart version, and adds supporting CI values and a Helm test secret template. Entity relationship diagram for test configuration changeserDiagram
TEST {
bool enabled
object image
bool injectTestNpmrcSecret
}
IMAGE {
string registry
string repository
string tag
}
TEST ||--o{ IMAGE : uses
Class diagram for test configuration and secret injectionclassDiagram
class TestConfig {
+bool enabled
+ImageConfig image
+bool injectTestNpmrcSecret
}
class ImageConfig {
+string registry
+string repository
+string tag
}
class OrchestratorConfig {
+bool enabled
}
class SecretTemplate {
<<new>>
+string npmrcSecret
}
TestConfig --> ImageConfig
TestConfig --> SecretTemplate : injects when injectTestNpmrcSecret==true
OrchestratorConfig <.. TestConfig : tested with
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of the change
Manual cherry-pick of #195 (comment)
Which issue(s) does this PR fix or relate to
Fixes https://issues.redhat.com/browse/RHDHBUGS-1893
How to test changes / Special notes to the reviewer
Checklist
Chart.yamlaccording to Semantic Versioning.values.yamland added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes. The pre-commit Workflow will do this automatically for you if needed.pre-commithook.ct lintcommand.Summary by Sourcery
Enable injecting a user-provided .npmrc secret for dynamic plugins in helm test workflows and update chart version and documentation accordingly
Enhancements:
Documentation:
Chores: