Skip to content

bumping osl version to 1.36 in orchestrator-infra - #213

Merged
gazarenkov merged 2 commits into
redhat-developer:release-1.7from
elai-shalev:bump-osl-version
Aug 13, 2025
Merged

bumping osl version to 1.36 in orchestrator-infra#213
gazarenkov merged 2 commits into
redhat-developer:release-1.7from
elai-shalev:bump-osl-version

Conversation

@elai-shalev

@elai-shalev elai-shalev commented Aug 10, 2025

Copy link
Copy Markdown

This PR is a backport of the fix introduced to main here: #201
We need to bump the default OSL version in orchestrator-infra chart, as Orchestrater now requires most recent version.

The Chart version in this PR has remained 0.1.0 to indicate the first release of the chart.
Related to this bug: https://issues.redhat.com/browse/FLPATH-2543

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Summary by Sourcery

Backport the fix to bump the default OpenShift Serverless Logic (OSL) operator version in the orchestrator-infra Helm chart to 1.36.0.

Enhancements:

  • Update default serverlessLogicOperator.subscription.startingCSV from logic-operator-rhel8.v1.35.0 to v1.36.0 in the chart values and README
  • Refresh CRD extraction example commands in the README to reference serverless-operator-bundle:1.36.0

@sourcery-ai

sourcery-ai Bot commented Aug 10, 2025

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Backports the OpenShift Serverless Logic (OSL) operator version bump to 1.36.0 in the orchestrator-infra chart by updating default startingCSV values, CRD extraction commands, and fixing a documentation typo.

Entity relationship diagram for updated serverlessLogicOperator subscription version

erDiagram
    SERVERLESSLOGICOPERATOR ||--o| SUBSCRIPTION : has
    SUBSCRIPTION {
      string name
      string source
      string sourceNamespace
      string startingCSV
    }
    %% Updated startingCSV from v1.35.0 to v1.36.0
Loading

File-Level Changes

Change Details Files
Bumped default OSL operator version to 1.36.0
  • Updated serverlessLogicOperator.subscription.spec.startingCSV default version
  • Adjusted values.yaml startingCSV to v1.36.0
charts/orchestrator-infra/README.md
charts/orchestrator-infra/values.yaml
charts/orchestrator-infra/README.md.gotmpl
Updated bundle image tags in CRD extraction examples
  • Replaced serverless-operator-bundle tag from 1.35.0 to 1.36.0 in README commands
charts/orchestrator-infra/README.md
Corrected a documentation typo
  • Fixed misspelling of 'subscription' in README
charts/orchestrator-infra/README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@openshift-ci
openshift-ci Bot requested review from gazarenkov and rm3l August 10, 2025 07:17

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @elai-shalev - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@elai-shalev

Copy link
Copy Markdown
Author

@gazarenkov the CI is failing in the linter because I did not bump the version of the chart. AFAIU we want to release the chart at 0.1.0, correct? so bumping it now to 0.1.1 is not expected
please correct me if i'm wrong

@gazarenkov

Copy link
Copy Markdown
Member

Hi @elai-shalev
I think we need to bump it anyway, that is what expected by current CI, see: https://github.com/redhat-developer/rhdh-chart/blob/main/charts/backstage/Chart.yaml#L45
Do you see any problem with making it incremented to 0.1.1 ?

@sonarqubecloud

Copy link
Copy Markdown

@elai-shalev

Copy link
Copy Markdown
Author

@gazarenkov waiting for lgtm to merge

@gazarenkov
gazarenkov merged commit 35cab18 into redhat-developer:release-1.7 Aug 13, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants