fix(RHDHBUGS-2015): fix sonataflow DB ref name for replication architecture of PostgreSQL

[pmacik]

Description of the change

This PR changes RHDH DB ref name (adds -primary suffix) if the PostgreSQL architecture is set to replication to match the name of the DB service.

Which issue(s) does this PR fix or relate to

• RHDHBUGS-2015

How to test changes / Special notes to the reviewer

Set the upstream.postgresql.architecture=replication and upstream.postgresql.replication.enabled=true and other related Helm chart values and then enable Orchestrator plugin (orchestrator.enabled=true) - install Helm chart.

Checklist

• For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
• For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
• JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
• Tests pass using the Chart Testing tool and the ct lint command.
• If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Summary by Sourcery

Fix SonataFlow Helm chart to reference the primary PostgreSQL instance when replication is enabled and bump the chart version

Bug Fixes:

• Ensure serviceRef name, dbHost, and database creation commands append '-primary' suffix when PostgreSQL replication is enabled

Chores:

• Bump charts/backstage version to 4.5.7
• Update README version badge to 4.5.7

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rm3l]

/cc @elai-shalev

[openshift-ci]

@rm3l: GitHub didn't allow me to request PR reviews from the following users: elai-shalev.

Note that only redhat-developer members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @elai-shalev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rm3l]

This works with the default settings, but I can see here that the -primary suffix depends on the primary.name value.
And indeed, the RHDH pod crashes if I deploy with --set upstream.postgresql.architecture=replication --set upstream.postgresql.primary.name=my-prim.
That said, I guess we would still have an issue as the same hardcoded suffix is used in the upstream Backstage chart: https://github.com/backstage/charts/blob/main/charts/backstage/templates/_helpers.tpl#L39C50-L39C58
So fine for now with the default settings, but I think this should be reported and fixed in the upstream Backstage chart so that users can use a different primary name.

[pmacik]

Good point, thx.

[github-actions]

⚠️ Files changed after running the pre-commit hooks

Those changes should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rm3l]

/lgtm

[rm3l]

Cherry-picking this to 1.7, as requested in this comment.

/cherry-pick release-1.7

[openshift-cherrypick-robot]

@rm3l: #235 failed to apply on top of branch "release-1.7":

Applying: fix(RHDHBUGS-2015): fix sonataflow DB ref name for replication architecture of PostgreSQL
Using index info to reconstruct a base tree...
M	charts/backstage/Chart.yaml
Falling back to patching base and 3-way merge...
Auto-merging charts/backstage/Chart.yaml
CONFLICT (content): Merge conflict in charts/backstage/Chart.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix(RHDHBUGS-2015): fix sonataflow DB ref name for replication architecture of PostgreSQL

Details

In response to this:

Cherry-picking this to 1.7, as requested in this comment.

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.