ci(backstage): skip plugin downloads in PR checks and use chart defaults - #480
Conversation
|
/cherry-pick release-1.9 |
|
@rm3l: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR Summary by QodoCI: skip Backstage plugin downloads in PR checks, keep nightly coverage
AI Description
Diagram
High-Level Assessment
Files changed (14)
|
Switch the catalog index image tag from 1.10 to next, and disable dynamic plugin downloads in all CI values files to speed up PR test cycles. The chart features under test (deployment, config, probes) don't depend on actual plugins. - Set global.dynamic.includes to [] in every CI values file - Set lightspeed.plugins and orchestrator.plugins to [] in CI - Add helm_extra_args input to the test-charts action - Generate a nightly override from values.yaml to restore default plugin configuration in nightly runs Assisted-by: Claude
3b72a23 to
d963323
Compare
Code Review by Qodo
Context used 1. Nightly override ignored
|
Add --proto =https to the curl command so redirects cannot downgrade to plain HTTP. Assisted-by: Claude
|
/cherry-pick release-1.9 |
|
@rm3l: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Stop overriding the backstage image repository and tag in the PR test workflow. The chart defaults from values.yaml are used instead. Assisted-by: Claude
Run helm template for each CI values file with the default plugin configuration restored on top, before creating the KinD cluster. This catches template rendering regressions in PR checks without the cost of a full install. Assisted-by: Claude
The bulk-import plugins are incompatible with the current Backstage version. Replace them with scaffolder-relation-processor and tech-radar from the rhdh-plugin-export-overlays OCI registry, which are both compatible (bs_1.52.0) and require no extra configuration. Assisted-by: Claude
Rename with-lightspeed-service-host.yaml to with-lightspeed-service-host-values.yaml so it matches the *-values.yaml pattern used by ct and the helm template sanity check. Also fix the glob to use *-values.yaml only. Assisted-by: Claude
ct's --upgrade flag runs a same-version self-upgrade test (helm install + helm upgrade) for every CI values file, even when the cross-version upgrade is already skipped due to a major version bump. This doubles test time without meaningful coverage. Conditionally omit --upgrade when a major version bump is detected vs. the target branch.
|
|
Merging to test the nightly workflows. |
|
@rm3l: #480 failed to apply on top of branch "release-1.9": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rm3l: #480 failed to apply on top of branch "release-1.10": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |



Description of the change
Speed up backstage chart PR tests and align CI with chart defaults:
nextcatalog index tag: switchglobal.catalogIndex.image.tagfrom1.10tonextglobal.dynamic.includes,lightspeed.plugins,and
orchestrator.pluginsto[]in all CI values files — the chart features under test(deployment, config, probes) don't depend on actual plugins
helm_extra_argsinput to the test-charts composite actionand generate a nightly override from
values.yaml(viayq) so nightly runs still exercisethe full plugin installation stack
from the PR test workflow so the chart's own
values.yamldefaults are usedWhich issue(s) does this PR fix or relate to
How to test changes / Special notes to the reviewer
values.yaml.values.yamlinstead of overriding it withrhdh/rhdh-hub-rhel9:latest.Checklist
Chart.yamlaccording to Semantic Versioning.values.yamland added to the corresponding README.md.pre-commithook.ct lintcommand.