feat: support optional .npmrc mount for dynamic plugin installation - #38
Closed
Fortune-Ndlovu wants to merge 0 commit into
Closed
Conversation
Member
Author
Member
|
@Fortune-Ndlovu can you please fix your git config? Your commits have |
Fortune-Ndlovu
force-pushed
the
load-external-plugins-from-.npmrc
branch
from
April 29, 2025 09:35
84ca29c to
7086b28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for optionally mounting a local .npmrc file into the install-dynamic-plugins container in RHDH Local, enabling developers to install dynamic plugins from private NPM registries without modifying the compose.yaml file.
What’s Included
.npmrcmount incompose.yaml, targeting the plugin installer containerNPM_CONFIG_USERCONFIGenv var, injected only if.npmrcis presentfixes.shto copy the mounted.npmrcto the correct location (~/.npmrc) for plugin installstart.shhelper script that:.npmrc(defaulting to$HOME/.npmrc)podman-compose.npmrcfor private pluginsBenefits
.npmrcno mount, no env, no errorsWhich issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer