chore(feat): support optional .npmrc mount for dynamic plugin installation - #40
Merged
rm3l merged 17 commits intoMay 12, 2025
Merged
Conversation
…ll-dynamic-plugins services volumes with the relevant bind. Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
…npmrc was mounted. Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
…ut modifying the compone.yaml. For example users can put their privae config at ~/secure/npmrc and just override with . Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
…Installation Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Fortune-Ndlovu
changed the title
Member
Author
|
cc: @kadel @benwilcock @rm3l for review please |
Member
|
/cc |
rm3l
reviewed
May 6, 2025
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
…file (./configs/extra-files/.npmrc), which doesn't always exist (e.g., in CI or on fresh clones), and Docker does not allow that. Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
…files Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
rm3l
requested changes
May 7, 2025
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
…allation behavior Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Member
Author
|
/lgtm @rm3l wdyt? |
rm3l
reviewed
May 12, 2025
rm3l
requested changes
May 12, 2025
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for optionally mounting a local
.npmrcfile into theinstall-dynamic-pluginscontainer in RHDH Local, enabling developers to install dynamic plugins from private NPM registries without modifying thecompose.yamlfile.fixes.shto detect ifconfigs/extra-files/.npmrcexists and setNPM_CONFIG_USERCONFIGenvironment variable dynamically.npmrc.exampletemplate underconfigs/extra-files/to guide usersREADME.mdto document the optional.npmrcsetup and fallback behaviorIf no
.npmrcis present, plugin installation continues using the default public registry settings.This change is fully backward-compatible and does not impact users who do not require private registry access.
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer