chore: Adding tech radar to RHDH Local - #89
Merged
Conversation
Signed-off-by: Leanne Ahern <lahern@redhat.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `configs/app-config/app-config.yaml:92` </location>
<code_context>
local:
publishDirectory: /tmp/techdocs
+
+techRadar:
+ url: https://raw.githubusercontent.com/backstage/community-plugins/main/workspaces/tech-radar/plugins/tech-radar-common/src/sampleTechRadarResponse.json
</code_context>
<issue_to_address>
Using a public GitHub URL for techRadar data may introduce reliability risks.
Consider hosting the data internally or adding a fallback to reduce the risk of outages if the external file becomes unavailable.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
rm3l
reviewed
Aug 29, 2025
Signed-off-by: Leanne Ahern <lahern@redhat.com>
rm3l
reviewed
Aug 29, 2025
rm3l
left a comment
rm3l
left a comment
Member
There was a problem hiding this comment.
@OpinionatedHeron Your PR is still marked as wip. Is it ready to be approved now or did you want to add anything else?
OpinionatedHeron
changed the title
Member
Author
|
@rm3l updated it now. Sorry, just wanted to be sure there were no suggestions from anyone else, before changing it. Should be all good now. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding Tech Radar plugin to default configuration of RHDH Local
Which issue(s) does this PR fix or relate to
RHIDP-8507
PR acceptance criteria
How to test changes / Special notes to the reviewer
Summary by Sourcery
Add Tech Radar integration to default RHDH Local setup
New Features:
Enhancements: