Enable plugin dependencies - #1046
Conversation
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
gazarenkov
changed the title
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
|
@gazarenkov does the operator run with admin rights? I'm trying to understand how the operator can create various resources on the cluster without RBAC (e.g. knative-eventing). Unless the client to apply the manifests is using cluster-admin perms. |
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
The part creating cluster level infrastructure (e.g. knative-eventing) is a part of operator deployment, it is performed by user (or something on behalf of user, e g olm) which has to have admin level rbac. |
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Co-authored-by: gazarenkov <gazarenkov@users.noreply.github.com>
|
|
Co-authored-by: gazarenkov <gazarenkov@users.noreply.github.com>
|
|
| apiVersion: operator.knative.dev/v1beta1 | ||
| kind: KnativeEventing | ||
| metadata: | ||
| name: knative-eventing | ||
| namespace: knative-eventing | ||
| spec: | ||
| Registry: {} | ||
| --- | ||
| apiVersion: operator.knative.dev/v1beta1 | ||
| kind: KnativeServing | ||
| metadata: | ||
| name: knative-serving | ||
| namespace: knative-serving | ||
| spec: | ||
| controller-custom-certs: | ||
| name: "" | ||
| type: "" | ||
| registry: {} |
There was a problem hiding this comment.
These are cluster-wide resources. Shouldn't they be moved to plugin-infra, similar to what is done in the orchestrator-infra Helm Chart? https://github.com/redhat-developer/rhdh-chart/blob/main/charts/orchestrator-infra/templates/serverless/knatives.yaml#L28-L54
(I guess you would have the same issue with the CRDs then..)
There was a problem hiding this comment.
They are cluster wide but not sure they can be considered as "infra".
Can we discuss it separately, I think it can wait for next PRs ?
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
Description
Enable plugin k8s dependencies (the k8s resources to create/merge to make plugin work) by example of Orchestrator plugin on rhdh profile.
Which issue(s) does this PR fix or relate to
https://issues.redhat.com/browse/RHIDP-6629
PR acceptance criteria
How to test changes / Special notes to the reviewer
Note: by default Orchestrator plugin with dependencies is DISABLED on RHDH profile. To enable it:
make image-build image-push IMG={your-image}and deploy operator withmake plugin-infra deploy IMG={your-image}OR
make install plugin-infra runoc apply -f {your-cr.yaml}(preferable on empty namespace for better visibility) and check the pods on its namespace, there should be no 5 pods in progress, wait until all of them are Running (it takes about 5 minutes on my cluster and several attempts for some pods). You also can check the status of your Backstage CR.