Skip to content

chore: add ENV EXTERNAL_SOURCE to Dockerfile - #1142

Merged
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:mainfrom
gazarenkov:ext-source-dockerfile
May 15, 2025
Merged

chore: add ENV EXTERNAL_SOURCE to Dockerfile#1142
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:mainfrom
gazarenkov:ext-source-dockerfile

Conversation

@gazarenkov

@gazarenkov gazarenkov commented May 13, 2025

Copy link
Copy Markdown
Member

Description

make image-build

1 warning found (use docker --debug to expand):
- UndefinedVar: Usage of undefined variable '$EXTERNAL_SOURCE' (line 59)

PR acceptance criteria

  • Tests

@gazarenkov
add ENV EXTERNAL_SOURCE
073508a 
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
@gazarenkov
gazarenkov requested review from nickboldt and rm3l May 13, 2025 06:28
@github-actions

github-actions Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.7.0-pr-1142-073508a
  2. https://quay.io/rhdh-community/operator-bundle:0.7.0-pr-1142-073508a
  3. https://quay.io/rhdh-community/operator-catalog:0.7.0-pr-1142-073508a

rm3l
rm3l reviewed May 13, 2025
View reviewed changes
Comment thread Dockerfile
@nickboldt
apply same fix in .rhdh/docker/Dockerfile too
a292848 
Signed-off-by: Nick Boldt <nboldt@redhat.com>
nickboldt
nickboldt approved these changes May 15, 2025
View reviewed changes

@nickboldt nickboldt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label May 15, 2025
@openshift-ci

openshift-ci Bot commented May 15, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented May 15, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.7.0-pr-1142-a292848
  2. https://quay.io/rhdh-community/operator-bundle:0.7.0-pr-1142-a292848
  3. https://quay.io/rhdh-community/operator-catalog:0.7.0-pr-1142-a292848

@openshift-merge-bot
openshift-merge-bot Bot merged commit ac6ab4e into redhat-developer:main May 15, 2025
@gazarenkov
gazarenkov deleted the ext-source-dockerfile branch May 16, 2025 07:37
Fortune-Ndlovu pushed a commit to Fortune-Ndlovu/rhdh-operator that referenced this pull request Sep 6, 2025
@gazarenkov @nickboldt
chore: add ENV EXTERNAL_SOURCE to Dockerfile (redhat-developer#1142)
1888d2d 
* add ENV EXTERNAL_SOURCE

Signed-off-by: gazarenkov <gazarenkov@gmail.com>

* apply same fix in .rhdh/docker/Dockerfile too

Signed-off-by: Nick Boldt <nboldt@redhat.com>

---------

Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
@rhdh-qodo-merge rhdh-qodo-merge Bot mentioned this pull request Jul 31, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l left review comments
@nickboldt nickboldt nickboldt approved these changes

Assignees

@nickboldt nickboldt

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gazarenkov @nickboldt @rm3l