Skip to content

chore: Bump to Golang 1.23 [RHIDP-5963] - #1222

Merged
rm3l merged 7 commits into
redhat-developer:mainfrom
rm3l:rhidp-5963-update-operator-to-golang-1.23
Jun 4, 2025
Merged

chore: Bump to Golang 1.23 [RHIDP-5963]#1222
rm3l merged 7 commits into
redhat-developer:mainfrom
rm3l:rhidp-5963-update-operator-to-golang-1.23

Conversation

@rm3l

@rm3l rm3l commented Jun 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Bumps Go to 1.23, now that registry.redhat.io/ubi9/go-toolset:1.23 is available. It also bumps the base ubi-minimal image to 9.6 (latest available at this time).

Which issue(s) does this PR fix or relate to

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

All tests (unit, integration and E2E) are passing, and I also performed a manual sanity check of quay.io/rhdh-community/operator-catalog:0.7.0-pr-1222-feda404.

@openshift-ci

openshift-ci Bot commented Jun 3, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kim-tsao for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rm3l
rm3l force-pushed the rhidp-5963-update-operator-to-golang-1.23 branch from 96b6ec0 to 5827041 Compare June 3, 2025 14:18
@rm3l
rm3l force-pushed the rhidp-5963-update-operator-to-golang-1.23 branch from 5827041 to d59a4e9 Compare June 3, 2025 17:04
@github-actions

github-actions Bot commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.7.0-pr-1222-d59a4e9
  2. https://quay.io/rhdh-community/operator-bundle:0.7.0-pr-1222-d59a4e9
  3. https://quay.io/rhdh-community/operator-catalog:0.7.0-pr-1222-d59a4e9

@rm3l rm3l changed the title [WIP] chore: Update to Golang 1.23 chore: Bump to Golang 1.23 Jun 3, 2025
@rm3l
rm3l marked this pull request as ready for review June 3, 2025 18:58
@openshift-ci
openshift-ci Bot requested review from kim-tsao and nickboldt June 3, 2025 18:58
rm3l added 2 commits June 3, 2025 21:00
@rm3l
Bump Go to 1.23 and ubi-minimal image to 9.6
3e85507
@rm3l
Bump golangci-lint to v1.64.8
4ef5b48 
Go 1.23 support was added in v1.60.1

NOTE: Bumping to the latest v2 required more changes in the code itself, due to more linters (I guess). And since this is outside the scope of this (Go 1.23 update), we can do this in a separate issue/PR
@rm3l
rm3l force-pushed the rhidp-5963-update-operator-to-golang-1.23 branch from d59a4e9 to 4ef5b48 Compare June 3, 2025 19:00
@rm3l rm3l changed the title chore: Bump to Golang 1.23 chore: Bump to Golang 1.23 [RHIDP-5963] Jun 3, 2025
rm3l
rm3l commented Jun 3, 2025
View reviewed changes
Comment thread Makefile
CONTROLLER_TOOLS_VERSION ?= v0.14.0
ENVTEST_VERSION ?= release-0.17
GOLANGCI_LINT_VERSION ?= v1.59.1
GOLANGCI_LINT_VERSION ?= v1.64.8

@rm3l rm3l Jun 3, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As seen in https://github.com/redhat-developer/rhdh-operator/actions/runs/15419859301/job/43391791587?pr=1222, v1.59.1 could not run using Go 1.23. Hence this update. However, this is the latest v1 version of golangci-lint that could pass with Go 1.23.
This is not the latest v2 version at this time, because v2 reports a lot of errors, which might require further investigation (outside of the scope of this PR). I'll create a subsequent issue/PR to upgrade golang-ci-lint to v2 and address the errors returned.

@github-actions

github-actions Bot commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.7.0-pr-1222-4ef5b48
  2. https://quay.io/rhdh-community/operator-bundle:0.7.0-pr-1222-4ef5b48
  3. https://quay.io/rhdh-community/operator-catalog:0.7.0-pr-1222-4ef5b48

nickboldt
nickboldt reviewed Jun 3, 2025
View reviewed changes
Comment thread go.mod
nickboldt
nickboldt reviewed Jun 3, 2025
View reviewed changes
Comment thread .rhdh/docker/Dockerfile Outdated
nickboldt
nickboldt reviewed Jun 3, 2025
View reviewed changes
Comment thread .rhdh/docker/Dockerfile Outdated
nickboldt
nickboldt reviewed Jun 3, 2025
View reviewed changes
Comment thread Dockerfile Outdated
nickboldt
nickboldt reviewed Jun 3, 2025
View reviewed changes
Comment thread Dockerfile Outdated
@rm3l @nickboldt
Apply suggestions from code review
bca2463 
Co-authored-by: Nick Boldt <nboldt@redhat.com>
rm3l
rm3l commented Jun 4, 2025
View reviewed changes
Comment thread api/v1alpha1/zz_generated.deepcopy.go Outdated
Comment thread api/v1alpha2/zz_generated.deepcopy.go Outdated
Comment thread api/v1alpha3/zz_generated.deepcopy.go Outdated
@github-actions

github-actions Bot commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.7.0-pr-1222-feda404
  2. https://quay.io/rhdh-community/operator-bundle:0.7.0-pr-1222-feda404
  3. https://quay.io/rhdh-community/operator-catalog:0.7.0-pr-1222-feda404

@rm3l
rm3l merged commit f95c226 into redhat-developer:main Jun 4, 2025
@rm3l
rm3l deleted the rhidp-5963-update-operator-to-golang-1.23 branch June 4, 2025 10:45
@rm3l rm3l mentioned this pull request Jun 4, 2025
Merged
2 tasks
Fortune-Ndlovu pushed a commit to Fortune-Ndlovu/rhdh-operator that referenced this pull request Sep 6, 2025
@rm3l @nickboldt
chore: Bump to Golang 1.23 [RHIDP-5963] (redhat-developer#1222)
a34e528 
* Bump Go to 1.23 and ubi-minimal image to 9.6

* Bump golangci-lint to v1.64.8

Go 1.23 support was added in v1.60.1

NOTE: Bumping to the latest v2 required more changes in the code itself, due to more linters (I guess). And since this is outside the scope of this (Go 1.23 update), we can do this in a separate issue/PR

* Apply suggestions from code review

Co-authored-by: Nick Boldt <nboldt@redhat.com>

* fixup! Bump Go to 1.23 and ubi-minimal image to 9.6

* Cleanup imports

* Fix import statements in zz_generated_deepcopy.go files

---------

Co-authored-by: Nick Boldt <nboldt@redhat.com>
@rhdh-qodo-merge rhdh-qodo-merge Bot mentioned this pull request Jul 31, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickboldt nickboldt nickboldt left review comments
@kim-tsao kim-tsao Awaiting requested review from kim-tsao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rm3l @nickboldt