chore: fix integration tests v1alpha3 and v1alpha4 - #1451
Merged
openshift-merge-bot[bot] merged 3 commits intoJul 25, 2025
Conversation
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
…test.go since its not related to config refresh functionality, need its own file. Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Contributor
Reviewer's GuideRefactor integration tests by extracting v1alpha3/v1alpha4 compatibility tests into a dedicated file, register all API versions in the test suite, and regenerate deep-copy code for v1alpha1–v1alpha4. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @Fortune-Ndlovu - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Jul 25, 2025
aca97c1
into
redhat-developer:main
7 checks passed
Fortune-Ndlovu
added a commit
to Fortune-Ndlovu/rhdh-operator
that referenced
this pull request
Sep 6, 2025
…1451) * ensure all api versions are properly registered Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com> * update: the api compatibility test does not belong in config-refresh_test.go since its not related to config refresh functionality, need its own file. Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com> * naming issue Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com> --------- Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes failing integration tests by registering all API versions (v1alpha1-v1alpha4) in the Kubernetes client scheme, resolving the "no kind is registered for the type v1alpha3.Backstage" error. Additionally, it improves test organization by moving the API compatibility test from
config-refresh_test.goto a dedicatedcr-compatibility_test.gofile, ensuring each test file has a clear, focused purpose.Which issue(s) does this PR fix or relate to
https://issues.redhat.com/browse/RHDHBUGS-1907
PR acceptance criteria
How to test changes / Special notes to the reviewer
Summary by Sourcery
Extract and centralize API version compatibility tests, update test scheme registration, and refresh generated deepcopy code
Enhancements:
Tests:
Chores: