fix: improve v1alpha3/v1alpha4 API compatibility integration test - #1479
Conversation
Reviewer's GuideRefactor the integration test to validate deployment spec creation instead of pod readiness, reduce execution timeouts, and update test descriptions for improved reliability and clarity across v1alpha3/v1alpha4 API compatibility scenarios. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Hey @Fortune-Ndlovu - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- Focus on deployment creation rather than pod readiness for API compatibility testing - Check deployment specs (replicas=1) instead of waiting for ReadyReplicas > 0 - Reduce timeouts from 3-6 minutes to 30 seconds for faster execution - Test core operator functionality: creating deployments with correct specifications - Validate API coexistence without depending on external factors like image pulls - Resolves integration test timeouts and improves test reliability This change makes the integration test focus on what it should actually test: whether the operator can successfully create and manage deployments using both v1alpha3 and v1alpha4 APIs, rather than testing pod startup which depends on many external factors. Test results on test-main branch show this reduces test time from 320+ seconds (with failures) to 10 seconds (with success).
625cced to
2aa3023
Compare
…gration-test-v1alpha4-api-compatibility fix: improve v1alpha3/v1alpha4 API compatibility integration test
This change makes the integration test focus on what it should actually test: whether the operator can successfully create and manage deployments using both v1alpha3 and v1alpha4 APIs, rather than testing pod startup which depends on many external factors.
Test results on test-main branch show this reduces test time from 320+ seconds (with failures) to 10 seconds (with success).
Description
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer
Summary by Sourcery
Improve the v1alpha3/v1alpha4 API compatibility integration test by validating deployment specs and reducing timeouts to speed up and stabilize execution
Enhancements:
Tests: