Remove forcibly deleting resources that cannot be patched

[gazarenkov]

Description

Remove forcibly deleting resources that cannot be patched

Which issue(s) does this PR fix or relate to

https://issues.redhat.com/browse/RHDHBUGS-1898

PR acceptance criteria

• Tests

Summary by Sourcery

Remove force-deletion fallback for unpatchable resources and clean up related logic

Bug Fixes:

• Prevent forcible deletion of resources on patch failures by removing the upgrade glitch workaround

Enhancements:

• Simplify applyPayload to directly return patch errors instead of deleting resources
• Streamline monitoring log output when ServiceMonitor is disabled

CI:

• Update Renovate workflow to always use the latest version and clarify the step name

Tests:

• Add missing newline at end of the cr-compatibility integration test

Chores:

• Regenerate deepcopy functions across all API versions

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removed forced deletion fallback for unpatchable resources by simplifying patch error handling and deleting the tryToFixUpgradeGlitch method; refined monitoring logs; updated Renovate CI step; added missing newline in test; regenerated deepcopy files.

Sequence diagram for simplified patch error handling in BackstageReconciler

sequenceDiagram
participant BackstageReconciler
participant KubernetesAPI
BackstageReconciler->>KubernetesAPI: Patch resource (Apply)
KubernetesAPI-->>BackstageReconciler: Error (patch failed)
BackstageReconciler-->>BackstageReconciler: Return error (no forced delete fallback)

Loading

Class diagram for BackstageReconciler after removal of tryToFixUpgradeGlitch

classDiagram
class BackstageReconciler {
  +applyPayload(ctx, obj)
  +applyServiceMonitor(ctx, backstage)
  +SetupWithManager(mgr)
  -tryToFixUpgradeGlitch(ctx, obj, inError) [REMOVED]
}

Loading

File-Level Changes

Change	Details	Files
Simplify patch error handling and remove fallback deletion logic	Replace tryToFixUpgradeGlitch call with direct error return Remove tryToFixUpgradeGlitch method including orphan deletion and log messages Wrap patch errors with descriptive message	internal/controller/backstage_controller.go
Refine monitoring log messages	Remove 'Checking monitoring status' log Lowercase and adjust disabled monitoring log message	internal/controller/monitor.go
Update Renovate CI version print step	Rename step to 'Print actual renovate version' Add comment to enforce using latest renovate version	.github/workflows/renovate-checks.yaml
Add missing newline at end of test file	Add trailing newline	integration_tests/cr-compatibility_test.go
Regenerate deepcopy files	Regenerate zz_generated.deepcopy.go for API versions	api/v1alpha1/zz_generated.deepcopy.go api/v1alpha2/zz_generated.deepcopy.go api/v1alpha3/zz_generated.deepcopy.go api/v1alpha4/zz_generated.deepcopy.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

PR images are available:

1. https://quay.io/rhdh-community/operator:0.8.0-pr-1515-b315861
2. https://quay.io/rhdh-community/operator-bundle:0.8.0-pr-1515-b315861
3. https://quay.io/rhdh-community/operator-catalog:0.8.0-pr-1515-b315861

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rm3l]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment