Skip to content

[release-1.6] ci: Fix authorization logic in pull_request_target workflows (#1563) - #1565

Merged
rm3l merged 1 commit into
redhat-developer:release-1.6from
rm3l:ci_fix_authz_logic_on_pull_request_target_workflows-release-1.6
Aug 28, 2025
Merged

[release-1.6] ci: Fix authorization logic in pull_request_target workflows (#1563)#1565
rm3l merged 1 commit into
redhat-developer:release-1.6from
rm3l:ci_fix_authz_logic_on_pull_request_target_workflows-release-1.6

Conversation

@rm3l

@rm3l rm3l commented Aug 27, 2025

Copy link
Copy Markdown
Member

Description

Manual cherry-pick of #1563

Summary by Sourcery

Fix the pull_request_target CI workflows by updating the authorization logic to use the PR author’s login against an updated approvers list and by checking out the exact commit SHA rather than the branch ref.

CI:

  • Determine internal/external environment using github.event.pull_request.user.login with a revised approvers list
  • Use github.event.pull_request.head.sha for the checkout ref instead of head.ref in PR workflows

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

On hold until 1.6.4 is out.

@openshift-ci

openshift-ci Bot commented Aug 27, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rm3l
rm3l merged commit 8111ba0 into redhat-developer:release-1.6 Aug 28, 2025
6 of 7 checks passed
@rm3l
rm3l deleted the ci_fix_authz_logic_on_pull_request_target_workflows-release-1.6 branch August 28, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant