[chore] Updating golangci-lint version and correcting errors and checks

[OpinionatedHeron]

Description

Updated the golangci-lint to v2.5.0. Ran 'make lint' and fixed or ignored any errors and checks that were flagged by the linter.

Which issue(s) does this PR fix or relate to

• RHDHBUGS-599

PR acceptance criteria

• Tests
• Documentation

How to test changes / Special notes to the reviewer

Ran 'make lint' until 0 errors returned.
Also ran 'make tests' to ensure tests still worked as expected.

[rm3l]

@OpinionatedHeron Please update your PR branch, so that the CI checks can run correctly. Thanks.

[github-actions]

PR images are available:

1. https://quay.io/rhdh-community/operator:0.9.0-pr-1797-fa25b41
2. https://quay.io/rhdh-community/operator-bundle:0.9.0-pr-1797-fa25b41
3. https://quay.io/rhdh-community/operator-catalog:0.9.0-pr-1797-fa25b41

[Fortune-Ndlovu]

/lgtm

[rm3l]

/review

[qodo-code-review]

You are above your monthly Qodo Merge usage quota. For more information, please visit here.

[rhdh-qodo-merge]

You are above your monthly Qodo Merge usage quota. For more information, please visit here.

[zdrapela]

/review

[rhdh-qodo-merge]

PR Reviewer Guide 🔍

(Review updated until commit fa25b41)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 RHDHBUGS-599 - Partially compliant Compliant requirements: Fix linter-reported errors or provide code comments justifying any ignored findings. Ensure make lint passes. Non-compliant requirements: Bump golangci-lint to the latest available version (v2.1.6 at ticket time). Requires further human verification: Verify that make lint passes in CI with updated toolchain on clean environment. Confirm that upgrading to golangci-lint v2.5.0 (newer than v2.1.6) is acceptable per ticket scope, or align to exactly the "latest available" per ticket at merge time.

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🔒 No security concerns identified

⚡ Recommended focus areas for review Ticket Mismatch The ticket specifies "latest available version (v2.1.6 at the time of writing)". PR bumps to v2.5.0. Confirm product decision that using a newer v2 is acceptable or adjust to the ticket-stated version. GINKGO ?= $(LOCALBIN)/ginkgo-$(GINKGO_VERSION) ## Tool Versions KUSTOMIZE_VERSION ?= v5.4.2 CONTROLLER_TOOLS_VERSION ?= v0.14.0 ENVTEST_VERSION ?= release-0.17 GOLANGCI_LINT_VERSION ?= v2.5.0 GOIMPORTS_VERSION ?= v0.16.1 GOSEC_VERSION ?= v2.22.8 GINKGO_VERSION ?= v2.22.2 Behavior Change Switched from r.Client.Get to embedded r.Get. Ensure reconciler embeds client.Client; otherwise this could change behavior or break dependency injection in tests. func (r *BackstageReconciler) getOCPIngressDomain() (string, error) { var u unstructured.Unstructured u.SetGroupVersionKind(schema.GroupVersionKind{ Group: "config.openshift.io", Kind: "Ingress", Version: "v1", }) err := r.Get(context.Background(), client.ObjectKey{ Name: "cluster", Namespace: "", }, &u) if err != nil { Nil Map Access Accessing annotations via deploy.Spec.Template.GetAnnotations() is safer but confirm no unintended behavior if annotations are nil; ensure equality logic still works as expected for empty maps. lg.V(1).Info("request by label, deployment not found", "name", model.DeploymentName(backstage.Name)) } else { lg.Error(err, "request by label failed, get Deployment ", "error ", err) } return []reconcile.Request{} } newHash := ec.WatchingHash oldHash := deploy.Spec.Template.GetAnnotations()[model.ExtConfigHashAnnotation] if newHash == oldHash { lg.V(1).Info("request by label, hash are equal", "hash", newHash) return []reconcile.Request{} }

📄 References No matching references available

[qodo-code-review]

Persistent review updated to latest commit fa25b41

[github-actions]

PR images are available:

1. https://quay.io/rhdh-community/operator:0.9.0-pr-1797-d727d34
2. https://quay.io/rhdh-community/operator-bundle:0.9.0-pr-1797-d727d34
3. https://quay.io/rhdh-community/operator-catalog:0.9.0-pr-1797-d727d34

[github-actions]

PR images are available:

1. https://quay.io/rhdh-community/operator:0.9.0-pr-1797-d689cdb
2. https://quay.io/rhdh-community/operator-bundle:0.9.0-pr-1797-d689cdb
3. https://quay.io/rhdh-community/operator-catalog:0.9.0-pr-1797-d689cdb

[github-actions]

PR images are available:

1. https://quay.io/rhdh-community/operator:0.9.0-pr-1797-dfb4161
2. https://quay.io/rhdh-community/operator-bundle:0.9.0-pr-1797-dfb4161
3. https://quay.io/rhdh-community/operator-catalog:0.9.0-pr-1797-dfb4161

[github-actions]

PR images are available:

1. https://quay.io/rhdh-community/operator:0.9.0-pr-1797-16f5487
2. https://quay.io/rhdh-community/operator-bundle:0.9.0-pr-1797-16f5487
3. https://quay.io/rhdh-community/operator-catalog:0.9.0-pr-1797-16f5487

[rm3l]

Thanks for your work on this !!

/lgtm

[rm3l]

nit: staticcheck should already be part of the linters enabled by default.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fortune-Ndlovu, rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rm3l]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment