Skip to content

avoid using pull_request_target in workflows - #2293

Merged
gazarenkov merged 14 commits into
redhat-developer:mainfrom
gazarenkov:avoid-pull_request_target
Jun 24, 2026
Merged

avoid using pull_request_target in workflows#2293
gazarenkov merged 14 commits into
redhat-developer:mainfrom
gazarenkov:avoid-pull_request_target

Conversation

@gazarenkov

@gazarenkov gazarenkov commented Feb 9, 2026

Copy link
Copy Markdown
Member

Description

Avoid using pull_request_target in workflows in workflows

Building Container Images for Testing

Need to test container images from this PR?

For Maintainers: Comment /build-images to trigger image builds
For Contributors: Ask a maintainer to run /build-images

Images will be built and pushed to Quay with links posted in comments.

@openshift-ci

openshift-ci Bot commented Feb 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nickboldt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gazarenkov
gazarenkov marked this pull request as ready for review February 9, 2026 18:49
@openshift-ci openshift-ci Bot added the lgtm label Jun 24, 2026
@rm3l

rm3l commented Jun 24, 2026

Copy link
Copy Markdown
Member

/override "PR Publish"
/override "PR Bundle Diff"
/override "PR Validate"

Those were triggered on pull_request_target.

@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

@rm3l: Overrode contexts on behalf of rm3l: PR Bundle Diff, PR Publish, PR Validate

Details

In response to this:

/override "PR Publish"
/override "PR Bundle Diff"
/override "PR Validate"

Those were triggered on pull_request_target.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rm3l

rm3l commented Jun 24, 2026

Copy link
Copy Markdown
Member

/cherry-pick release-1.10
/cherry-pick release-1.9

@openshift-cherrypick-robot

Copy link
Copy Markdown

@rm3l: once the present PR merges, I will cherry-pick it on top of release-1.10, release-1.9 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rm3l

rm3l commented Jun 24, 2026

Copy link
Copy Markdown
Member

/override "PR Publish"

Those were triggered on pull_request_target.

@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

@rm3l: Overrode contexts on behalf of rm3l: PR Publish

Details

In response to this:

/override "PR Publish"

Those were triggered on pull_request_target.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gazarenkov
gazarenkov merged commit 59554ed into redhat-developer:main Jun 24, 2026
10 of 15 checks passed
@sonarqubecloud

Copy link
Copy Markdown

@openshift-cherrypick-robot

Copy link
Copy Markdown

@rm3l: #2293 failed to apply on top of branch "release-1.10":

Applying: avoid using pull_request_target in workflows
Using index info to reconstruct a base tree...
M	.github/workflows/pr-bundle-diff-checks.yaml
M	.github/workflows/pr-container-build.yaml
M	.github/workflows/pr.yaml
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/pr-bundle-diff-checks.yaml
CONFLICT (content): Merge conflict in .github/workflows/pr-bundle-diff-checks.yaml
Auto-merging .github/workflows/pr-container-build.yaml
CONFLICT (content): Merge conflict in .github/workflows/pr-container-build.yaml
Auto-merging .github/workflows/pr.yaml
CONFLICT (content): Merge conflict in .github/workflows/pr.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 avoid using pull_request_target in workflows

Details

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@rm3l: #2293 failed to apply on top of branch "release-1.9":

Applying: avoid using pull_request_target in workflows
Using index info to reconstruct a base tree...
M	.github/workflows/pr-bundle-diff-checks.yaml
M	.github/workflows/pr-container-build.yaml
M	.github/workflows/pr.yaml
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/pr-bundle-diff-checks.yaml
Auto-merging .github/workflows/pr-container-build.yaml
CONFLICT (content): Merge conflict in .github/workflows/pr-container-build.yaml
Auto-merging .github/workflows/pr.yaml
CONFLICT (content): Merge conflict in .github/workflows/pr.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 avoid using pull_request_target in workflows

Details

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants