Skip to content

chore(lightspeed): sync config files from upstream - #2769

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
chore/sync-lightspeed-configs
May 4, 2026
Merged

chore(lightspeed): sync config files from upstream#2769
openshift-merge-bot[bot] merged 1 commit into
mainfrom
chore/sync-lightspeed-configs

Conversation

@github-actions

@github-actions github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Automated nightly sync of Lightspeed config files from redhat-ai-dev/lightspeed-configs.

Synced files

  • config/profile/rhdh/default-config/flavours/lightspeed/configmap-files.yaml
  • examples/lightspeed.yaml

Caution

Please review the upstream changes carefully before merging.

@rm3l rm3l closed this May 4, 2026
@rm3l rm3l reopened this May 4, 2026
@sonarqubecloud

sonarqubecloud Bot commented May 4, 2026

Copy link
Copy Markdown

@rm3l

rm3l commented May 4, 2026

Copy link
Copy Markdown
Member

/cc @Jdubrick

For review.
I manually triggered the "Sync Lightspeed Configs" workflow to test it: https://github.com/redhat-developer/rhdh-operator/actions/runs/25325406316
I guess this PR supersedes #2755, right?

@openshift-ci
openshift-ci Bot requested a review from Jdubrick May 4, 2026 14:47
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

@Jdubrick

Jdubrick commented May 4, 2026

Copy link
Copy Markdown
Contributor

/cc @Jdubrick

For review. I manually triggered the "Sync Lightspeed Configs" workflow to test it: https://github.com/redhat-developer/rhdh-operator/actions/runs/25325406316 I guess this PR supersedes #2755, right?

@rm3l yeah if we want to use this triggered PR then #2755 would be redundant now, since we merged the inherit functionality, and this PR from the workflow has the config changes. I am a bit concerned about those generated .go files though, I wonder if removing the v1 name is going to affect anything? Maybe it was just missed during a refactor somewhere and the bundle creation is trying to add it?

@rm3l

rm3l commented May 4, 2026

Copy link
Copy Markdown
Member

I am a bit concerned about those generated .go files though, I wonder if removing the v1 name is going to affect anything? Maybe it was just missed during a refactor somewhere and the bundle creation is trying to add it?

It is okay.. We noticed this behavior as well in those generated files a few months ago already (observed in CI and locally). It should be already tracked as tech debt issue IIRC.

@Jdubrick Jdubrick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lightspeed changes lgtm @rm3l

@openshift-ci openshift-ci Bot added the lgtm label May 4, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 7e2c80f into main May 4, 2026
9 checks passed
@openshift-merge-bot
openshift-merge-bot Bot deleted the chore/sync-lightspeed-configs branch May 4, 2026 16:53
Jdubrick pushed a commit to Jdubrick/rhdh-operator that referenced this pull request Jun 15, 2026
…2769)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants