Skip to content

do not allow multi entry app-config ConfigMap - #3021

Merged
gazarenkov merged 3 commits into
redhat-developer:mainfrom
gazarenkov:single-entry-appconfig-configmap
Jun 18, 2026
Merged

do not allow multi entry app-config ConfigMap#3021
gazarenkov merged 3 commits into
redhat-developer:mainfrom
gazarenkov:single-entry-appconfig-configmap

Conversation

@gazarenkov

Copy link
Copy Markdown
Member

Description

All app-config ConfigMaps must now contain exactly one data entry.
This ensures predictable merge order, as Kubernetes does not guarantee iteration order for ConfigMap data entries.
Users with multi-entry app-config ConfigMaps must split them into separate single-entry ConfigMaps. Note: it breaks existing deployments with multi-entry ConfigMaps.

Which issue(s) does this PR fix or relate to

https://redhat.atlassian.net/browse/RHIDP-14466

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

  • Create a "multi-config" ConfigMap for app-config with multiple (2 for ex) data: entries
  • Reference it in Backstage CR spec
  • Try to create this CR
  • Deployment fails with error message: "multiple entries (2) not allowed for app-config ConfigMap: multi-config"

Assisted-by: Cloude

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.54%. Comparing base (7bb196a) to head (e7ddbd1).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
+ Coverage   61.41%   61.54%   +0.12%     
==========================================
  Files          37       37              
  Lines        2159     2161       +2     
==========================================
+ Hits         1326     1330       +4     
+ Misses        691      690       -1     
+ Partials      142      141       -1     
Flag Coverage Δ
nightly ?
unittests 61.54% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/model/appconfig.go 88.46% <100.00%> (+4.46%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gazarenkov

Copy link
Copy Markdown
Member Author

/agentic_review

@gazarenkov gazarenkov changed the title Do not allow multi entry app-config ConfigMap do not allow multi entry app-config ConfigMap Jun 17, 2026
@rhdh-qodo-merge

Copy link
Copy Markdown

Looking for bugs?

Check back in a few minutes. Qodo's review agents are on it.

Comment thread pkg/model/appconfig.go Outdated
Co-authored-by: Armel Soro <armel@rm3l.org>
@sonarqubecloud

Copy link
Copy Markdown

@gazarenkov
gazarenkov merged commit 56c2ee4 into redhat-developer:main Jun 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants