Skip to content

add option to skip creating ICSP and add support for registry-proxy image references resolved from quay.io/rhdh/ (RHIDP-3205) - #330

Closed
nickboldt wants to merge 1 commit into
mainfrom
RHIDP-3205
Closed

add option to skip creating ICSP and add support for registry-proxy image references resolved from quay.io/rhdh/ (RHIDP-3205)#330
nickboldt wants to merge 1 commit into
mainfrom
RHIDP-3205

Conversation

@nickboldt

@nickboldt nickboldt commented Oct 9, 2024

Copy link
Copy Markdown
Member

What does this PR do?

add option to skip creating ICSP and add support for registry-proxy image references resolved from quay.io/rhdh/ (RHIDP-3205)

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/RHIDP-3205
https://issues.redhat.com/browse/RHIDP-4415

How to test this PR?

Unsure... see 4415 -- can't make the script worrk yet :(

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…mage references resolved from quay.io/rhdh/ (RHIDP-3205)

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@openshift-ci

openshift-ci Bot commented Oct 9, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nickboldt. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt changed the title add option to skip creating ICSP and add... add option to skip creating ICSP and add support for registry-proxy image references resolved from quay.io/rhdh/ (RHIDP-3205) Oct 9, 2024
@nickboldt
nickboldt marked this pull request as draft October 9, 2024 21:17
@rm3l

rm3l commented Feb 11, 2025

Copy link
Copy Markdown
Member

This PR should no longer be needed with the improvements made recently to the airgap install script. See #705 and #779

/close

@openshift-ci openshift-ci Bot closed this Feb 11, 2025
@openshift-ci

openshift-ci Bot commented Feb 11, 2025

Copy link
Copy Markdown

@rm3l: Closed this PR.

Details

In response to this:

This PR should no longer be needed with the improvements made recently to the airgap install script. See #705 and #779

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rm3l
rm3l deleted the RHIDP-3205 branch February 11, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants