Skip to content

chore: set readOnlyRootFilesystem on Operator Container - #740

Merged
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:mainfrom
coreydaley:2025-01-29-enable-readonlyfilesystem-on-operator-container
Feb 7, 2025
Merged

chore: set readOnlyRootFilesystem on Operator Container#740
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:mainfrom
coreydaley:2025-01-29-enable-readonlyfilesystem-on-operator-container

Conversation

@coreydaley

@coreydaley coreydaley commented Feb 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Sets the readOnlyRootFilesystem option for the container securityContext to true.

Which issue(s) does this PR fix or relate to

https://issues.redhat.com/browse/RHIDP-5762

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

@openshift-ci
openshift-ci Bot requested review from kim-tsao and nickboldt February 3, 2025 00:36
@github-actions @coreydaley
Regenerate bundle manifests
cfeb712 
Co-authored-by: coreydaley <coreydaley@users.noreply.github.com>
@github-actions

github-actions Bot commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.

@github-actions

github-actions Bot commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.5.0-pr-740-9873ca7
  2. https://quay.io/rhdh-community/operator-bundle:0.5.0-pr-740-9873ca7
  3. https://quay.io/rhdh-community/operator-catalog:0.5.0-pr-740-9873ca7

@rm3l rm3l closed this Feb 3, 2025
@rm3l rm3l reopened this Feb 3, 2025
@github-actions

github-actions Bot commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.5.0-pr-740-cfeb712
  2. https://quay.io/rhdh-community/operator-bundle:0.5.0-pr-740-cfeb712
  3. https://quay.io/rhdh-community/operator-catalog:0.5.0-pr-740-cfeb712

@coreydaley coreydaley changed the title [WIP] chore: set readOnlyRootFilesystem on Operator Container chore: set readOnlyRootFilesystem on Operator Container Feb 3, 2025
@coreydaley

coreydaley commented Feb 3, 2025

Copy link
Copy Markdown
Contributor Author

@rm3l @gazarenkov ptal

@openshift-ci openshift-ci Bot added the approved label Feb 4, 2025
@coreydaley

coreydaley commented Feb 5, 2025

Copy link
Copy Markdown
Contributor Author

@rm3l @gazarenkov Do either of you have any other questions or comments about this change? If not can I get an lgtm?

@rm3l

rm3l commented Feb 5, 2025

Copy link
Copy Markdown
Member

@rm3l @gazarenkov Do either of you have any other questions or comments about this change? If not can I get an lgtm?

It is fine for me. @gazarenkov PTAL and lgtm it if it looks good for you.

rm3l
rm3l approved these changes Feb 7, 2025
View reviewed changes

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Feb 7, 2025
@openshift-ci

openshift-ci Bot commented Feb 7, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rm3l

rm3l commented Feb 7, 2025

Copy link
Copy Markdown
Member

LGTM'ed to test this in the E2E Nightly workflow as soon as possible.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 813014d into redhat-developer:main Feb 7, 2025
Fortune-Ndlovu pushed a commit to Fortune-Ndlovu/rhdh-operator that referenced this pull request Sep 6, 2025
Corey Daley @github-actions @coreydaley
chore: set readOnlyRootFilesystem on Operator Container (redhat-devel…
333d2f9 
…oper#740)

* chore: set readOnlyRootFilesystem on Operator Container

* Regenerate bundle manifests

Co-authored-by: coreydaley <coreydaley@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: coreydaley <coreydaley@users.noreply.github.com>
@rhdh-qodo-merge rhdh-qodo-merge Bot mentioned this pull request Jul 8, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes
@kim-tsao kim-tsao Awaiting requested review from kim-tsao
@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

@gazarenkov gazarenkov

@rm3l rm3l

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coreydaley @rm3l @gazarenkov