Skip to content

Make initContainer root filesystem read-only - #766

Merged
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:mainfrom
coreydaley:2025-02-06-make-initcontainer-readonly
Feb 10, 2025
Merged

Make initContainer root filesystem read-only#766
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:mainfrom
coreydaley:2025-02-06-make-initcontainer-readonly

Conversation

@coreydaley

@coreydaley coreydaley commented Feb 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Sets the readOnlyRootFilesystem:true on the initContainer, has been tested with 1.3.x, 1.4.x, and next images

Which issue(s) does this PR fix or relate to

https://issues.redhat.com/browse/RHIDP-5887

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

@openshift-ci
openshift-ci Bot requested review from kadel and nickboldt February 7, 2025 00:23
@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.

@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.5.0-pr-766-f5243f8
  2. https://quay.io/rhdh-community/operator-bundle:0.5.0-pr-766-f5243f8
  3. https://quay.io/rhdh-community/operator-catalog:0.5.0-pr-766-f5243f8

@rm3l rm3l closed this Feb 7, 2025
@rm3l rm3l reopened this Feb 7, 2025
@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.5.0-pr-766-249a356
  2. https://quay.io/rhdh-community/operator-bundle:0.5.0-pr-766-249a356
  3. https://quay.io/rhdh-community/operator-catalog:0.5.0-pr-766-249a356

@coreydaley coreydaley changed the title [WIP] Make initContainer root filesystem read-only Make initContainer root filesystem read-only Feb 7, 2025
@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.

@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.5.0-pr-766-b2080b9
  2. https://quay.io/rhdh-community/operator-bundle:0.5.0-pr-766-b2080b9
  3. https://quay.io/rhdh-community/operator-catalog:0.5.0-pr-766-b2080b9

@coreydaley coreydaley closed this Feb 7, 2025
@coreydaley coreydaley reopened this Feb 7, 2025
@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.5.0-pr-766-8bb1188
  2. https://quay.io/rhdh-community/operator-bundle:0.5.0-pr-766-8bb1188
  3. https://quay.io/rhdh-community/operator-catalog:0.5.0-pr-766-8bb1188

@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.

@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.

@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.5.0-pr-766-4ebba06
  2. https://quay.io/rhdh-community/operator-bundle:0.5.0-pr-766-4ebba06
  3. https://quay.io/rhdh-community/operator-catalog:0.5.0-pr-766-4ebba06

@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.

@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.5.0-pr-766-135ff6e
  2. https://quay.io/rhdh-community/operator-bundle:0.5.0-pr-766-135ff6e
  3. https://quay.io/rhdh-community/operator-catalog:0.5.0-pr-766-135ff6e

@github-actions @coreydaley
Regenerate bundle manifests
52acf72 
Co-authored-by: coreydaley <coreydaley@users.noreply.github.com>
@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.

@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.5.0-pr-766-09b1ff8
  2. https://quay.io/rhdh-community/operator-bundle:0.5.0-pr-766-09b1ff8
  3. https://quay.io/rhdh-community/operator-catalog:0.5.0-pr-766-09b1ff8

@coreydaley coreydaley closed this Feb 7, 2025
@coreydaley coreydaley reopened this Feb 7, 2025
@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

PR images are available:

  1. https://quay.io/rhdh-community/operator:0.5.0-pr-766-52acf72
  2. https://quay.io/rhdh-community/operator-bundle:0.5.0-pr-766-52acf72
  3. https://quay.io/rhdh-community/operator-catalog:0.5.0-pr-766-52acf72

rm3l
rm3l approved these changes Feb 10, 2025
View reviewed changes

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Feb 10, 2025
@openshift-ci

openshift-ci Bot commented Feb 10, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 10fe366 into redhat-developer:main Feb 10, 2025
Fortune-Ndlovu pushed a commit to Fortune-Ndlovu/rhdh-operator that referenced this pull request Sep 6, 2025
Corey Daley @github-actions @coreydaley
Make initContainer root filesystem read-only (redhat-developer#766)
247e615 
* Make initContainer root filesystem readonly by default

* Regenerate bundle manifests

Co-authored-by: coreydaley <coreydaley@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: coreydaley <coreydaley@users.noreply.github.com>
@rhdh-qodo-merge rhdh-qodo-merge Bot mentioned this pull request Jul 8, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l rm3l approved these changes
@kadel kadel Awaiting requested review from kadel
@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

@gazarenkov gazarenkov

@rm3l rm3l

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coreydaley @rm3l @gazarenkov