Skip to content

Document scripts/load-secrets.sh and env var sync in boost AGENTS.md #4168

Description

@fullsend-ai-retro

What happened

On PR #4167, the code agent was tasked with renaming all llamastack references to ogx across the boost workspace. The agent successfully renamed 46 files (TypeScript, config, docs, tests) but missed workspaces/boost/scripts/load-secrets.sh, which exports BOOST_LLAMA_STACK_URL and defines _discover_llama_stack_route. This left the env var in load-secrets.sh out of sync with the renamed BOOST_OGX_URL reference in app-config.yaml, which would have caused a silent runtime fallback to http://localhost:8321.

The review agent caught this as a HIGH severity finding at 16:42 UTC. The human then had to manually trigger /fs-fix with specific instructions at ~17:14 UTC. The fix agent completed the rename in commit 0bd187d.

The root cause is that issue #4165 scoped the work to "typescript files, markdowns, or app-config.yaml examples" — shell scripts were not mentioned. More importantly, workspaces/boost/AGENTS.md does not document the scripts/ directory or load-secrets.sh at all, so the code agent had no way to discover this file was relevant.

What could go better

The code agent should have found load-secrets.sh during its rename sweep. The workspace AGENTS.md lists package structure (plugins/boost-backend-module-ogx, plugins/ogx-entity-provider, etc.) but does not mention the scripts/ directory. Since rename/refactor tasks inherently require comprehensive file discovery, the agent needs workspace documentation that covers all directories containing deployment-relevant configuration — not just plugin source code.

Confidence: HIGH — the causal chain is clear. The AGENTS.md omission is verifiable by reading the file. The code agent's behavior (following issue scope + AGENTS.md) is consistent with how agents use repo context. Adding this documentation would put load-secrets.sh in the agent's search scope for future tasks.

Proposed change

Add the scripts/ directory and load-secrets.sh to workspaces/boost/AGENTS.md. Specifically:

  1. Add a section documenting the scripts/ directory and its role in the deployment pipeline.
  2. Note that load-secrets.sh contains environment variable names (BOOST_OGX_URL) and route-discovery function names that must stay synchronized with the config keys in app-config.yaml (under boost.providers.ogx).
  3. Include a general note that rename or refactor tasks affecting config keys in app-config.yaml should also check scripts/load-secrets.sh for corresponding env var and function name references.

This is a small, targeted documentation addition — likely 5–10 lines in the existing AGENTS.md file.

Validation criteria

On the next code agent task that involves renaming or modifying config keys in the boost workspace's app-config.yaml, the agent should also check and update scripts/load-secrets.sh without requiring a separate /fs-fix iteration. Verify by checking whether future rename/refactor PRs in the boost workspace include load-secrets.sh changes in their initial commit when env vars or config keys are affected.


Generated by retro agent from #4167

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationready-for-triageRetro-filed issue awaiting triage agentready-to-codeworkspace/boostBoost workspace (Backstage AI plugin)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions