Skip to content

fix(extensions): clear processors logging #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzemanov merged 2 commits into from
Jul 24, 2025
Merged

fix(extensions): clear processors logging #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea95fd
Update log messages
dzemanov Jul 24, 2025
b01c18b
Switch to debug for now
dzemanov Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions workspaces/marketplace/.changeset/friendly-pugs-applaud.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@red-hat-developer-hub/backstage-plugin-catalog-backend-module-marketplace': patch
---

Clear processors log messages
8 changes: 4 additions & 4 deletions ...og-backend-module-marketplace/src/processors/DynamicPackageInstallStatusProcessor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ describe('DynamicPackageInstallStatusProcessor', () => {
);

expect(entity.spec?.installStatus).toBe(undefined);
expect(logger.warn).toHaveBeenCalledWith(
"Entity package:default/testpackage is missing spec.packageName, unable to determine 'spec.installStatus'",
expect(logger.debug).toHaveBeenCalledWith(
"Entity package:default/testpackage is missing 'spec.packageName', unable to determine 'spec.installStatus'",
);
});

Expand Down Expand Up @@ -199,8 +199,8 @@ describe('DynamicPackageInstallStatusProcessor', () => {
cache,
);
expect(result.spec?.installStatus).toBe(undefined);
expect(logger.warn).toHaveBeenCalledWith(
"Missing 'entity.spec.dynamicArtifact', unable to determine 'spec.installStatus'",
expect(logger.debug).toHaveBeenCalledWith(
"Entity package:default/testpackage is missing 'spec.dynamicArtifact', unable to determine 'spec.installStatus'",
);
});

Expand Down
12 changes: 6 additions & 6 deletions ...catalog-backend-module-marketplace/src/processors/DynamicPackageInstallStatusProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ export class DynamicPackageInstallStatusProcessor implements CatalogProcessor {
installedPackages: Plugins,
): MarketplacePackageInstallStatus | undefined {
if (!marketplacePackage.spec?.packageName) {
this.logger.warn(
"Missing 'entity.spec.packageName', unable to determine 'spec.installStatus'",
this.logger.debug(
`Entity ${stringifyEntityRef(marketplacePackage)} is missing 'spec.packageName', unable to determine 'spec.installStatus'`,
);
return undefined;
}
Expand Down Expand Up @@ -133,8 +133,8 @@ export class DynamicPackageInstallStatusProcessor implements CatalogProcessor {
}

if (!marketplacePackage.spec?.dynamicArtifact) {
this.logger.warn(
"Missing 'entity.spec.dynamicArtifact', unable to determine 'spec.installStatus'",
this.logger.debug(
`Entity ${stringifyEntityRef(marketplacePackage)} is missing 'spec.dynamicArtifact', unable to determine 'spec.installStatus'`,
);
return undefined;
}
Expand All @@ -155,8 +155,8 @@ export class DynamicPackageInstallStatusProcessor implements CatalogProcessor {
): Promise<Entity> {
if (isMarketplacePackage(entity)) {
if (!entity.spec?.packageName) {
this.logger.warn(
`Entity ${stringifyEntityRef(entity)} is missing spec.packageName, unable to determine 'spec.installStatus'`,
this.logger.debug(
`Entity ${stringifyEntityRef(entity)} is missing 'spec.packageName', unable to determine 'spec.installStatus'`,
);
return entity;
}
Expand Down
5 changes: 4 additions & 1 deletion ...s/catalog-backend-module-marketplace/src/processors/LocalPackageInstallStatusProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,10 @@ export class LocalPackageInstallStatusProcessor implements CatalogProcessor {

return null;
} catch (error) {
console.warn('xxx', error);
console.warn(
`Error occurred while processing local install status of ${packageName}`,
error,
);
return null;
}
}
Expand Down
10 changes: 5 additions & 5 deletions ...ns/catalog-backend-module-marketplace/src/processors/PluginInstallStatusProcessor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ describe('PluginInstallStatusProcessor', () => {
);

expect(entity.spec?.installStatus).toBe(undefined);
expect(logger.warn).toHaveBeenCalledWith(
expect(logger.debug).toHaveBeenCalledWith(
"Entity plugin:default/plugin1 is missing packages, unable to determine 'spec.installStatus'",
);
});
Expand Down Expand Up @@ -290,8 +290,8 @@ describe('PluginInstallStatusProcessor', () => {
);

expect(entity.spec?.installStatus).toBe(undefined);
expect(logger.warn).toHaveBeenCalledWith(
"Missing all definitions for plugin:marketplace-plugin-demo/marketplace packages installStatus, unable to determine 'spec.installStatus'",
expect(logger.debug).toHaveBeenCalledWith(
"Entity plugin:marketplace-plugin-demo/marketplace is missing all definitions of 'spec.installStatus' in its packages, unable to determine 'spec.installStatus'",
);
});

Expand All @@ -314,8 +314,8 @@ describe('PluginInstallStatusProcessor', () => {
);

expect(entity.spec?.installStatus).toBe(undefined);
expect(logger.warn).toHaveBeenCalledWith(
"Missing all definitions for plugin:marketplace-plugin-demo/marketplace packages installStatus, unable to determine 'spec.installStatus'",
expect(logger.debug).toHaveBeenCalledWith(
"Entity plugin:marketplace-plugin-demo/marketplace is missing all definitions of 'spec.installStatus' in its packages, unable to determine 'spec.installStatus'",
);
});

Expand Down
8 changes: 4 additions & 4 deletions ...plugins/catalog-backend-module-marketplace/src/processors/PluginInstallStatusProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export class PluginInstallStatusProcessor implements CatalogProcessor {
);

if (!pluginPackageRefs || pluginPackageRefs.length === 0) {
this.logger.warn(
this.logger.debug(
`Entity ${stringifyEntityRef(marketplacePlugin)} is missing 'spec.packages', unable to determine 'spec.installStatus'`,
);
return undefined;
Expand All @@ -205,8 +205,8 @@ export class PluginInstallStatusProcessor implements CatalogProcessor {
const pluginPackageStatuses =
await this.getPluginPackageInstallStatuses(pluginPackageRefs);
if (pluginPackageRefs.length !== pluginPackageStatuses.length) {
this.logger.warn(
`Missing all definitions for ${stringifyEntityRef(marketplacePlugin)} packages installStatus, unable to determine 'spec.installStatus'`,
this.logger.debug(
`Entity ${stringifyEntityRef(marketplacePlugin)} is missing all definitions of 'spec.installStatus' in its packages, unable to determine 'spec.installStatus'`,
);
return undefined;
}
Expand Down Expand Up @@ -261,7 +261,7 @@ export class PluginInstallStatusProcessor implements CatalogProcessor {
): Promise<Entity> {
if (isMarketplacePlugin(entity)) {
if (!entity.spec?.packages || entity.spec.packages.length === 0) {
this.logger.warn(
this.logger.debug(
`Entity ${stringifyEntityRef(entity)} is missing packages, unable to determine 'spec.installStatus'`,
);
return entity;
Expand Down