feat(lightspeed): chat history management by debsmita1 · Pull Request #1804 · redhat-developer/rhdh-plugins

debsmita1 · 2025-11-17T19:07:47Z

Hey, I just made a Pull Request!

Resolves:

Solution description:

Added missing translations for untranslated labels across the Lightspeed chat UI.
Added lightspeed settings kebab menu with actions to enable or disable pinned chats.
Added a new “Pinned” section. The section is conditionally visible only when pining chats is enabled in Lightspeed settings. It shows an empty state when no chats are pinned. Note: Persistence of pinned chats is not included in this PR. It will be implemented in a separate ticket.
Added Kebab menu actions to each chat item with actions: Rename, Pin, Unpin
Implemented logic to move chats between the Pinned and Recent sections based on the selected action (“Pin” / “Unpin”).
Updated search behavior to show results under both Pinned (when enabled) and Recent groups, including appropriate empty search messaging.
The Rename action opens a dialog with an editable text field and confirm/cancel actions.
Replaced the patternfly components with MUI to match the Figma designs Design 1
Design 2

GIF/Screenshots:

Screen.Recording.2025-11-19.at.12.42.38.AM.mov

Screen.Recording.2025-11-19.at.12.52.30.AM.mov

✔️ Checklist

A changeset describing the change and affected packages. (more info)
Added or Updated documentation
Tests for new functionality and regression tests for bug fixes
Screenshots attached (for UI changes)

rhdh-gh-app · 2025-11-17T19:08:07Z

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
app	workspaces/lightspeed/packages/app	none	`v0.0.0`
@red-hat-developer-hub/backstage-plugin-lightspeed-common	workspaces/lightspeed/plugins/lightspeed-common	patch	`v1.0.3`
@red-hat-developer-hub/backstage-plugin-lightspeed	workspaces/lightspeed/plugins/lightspeed	patch	`v1.0.3`

rohitkrai03

/lgtm

jrichter1 · 2025-11-19T09:50:58Z

With the changes we definitely need to update the playwright tests. If you need help with that, give me or @HusneShabbir a shout.

HusneShabbir

Could we update the Lightspeed settings kebab menu to be vertical here, similar to how it is in Figma?

HusneShabbir

/lgtm,
works as expected

aprilma419 · 2025-11-25T02:51:03Z

LGTM, thanks!

karthikjeeyar · 2025-11-25T10:04:34Z

Overall looks great 🎉 I have a couple of questions

Empty state text for unmatched search query shows No pinned chats and No recent chats, this feels incorrect and ambiguous.

No pinned chats and No recent chats options are clickable and clicking on it takes you to a new conversation. should It be clickable? Ideally it should be just a text not a button but if it is a limitation today can we disable it?

Clickable_pinned_items.mov

debsmita1 · 2025-11-25T10:43:37Z

Overall looks great 🎉 I have a couple of questions

Empty state text for unmatched search query shows No pinned chats and No recent chats, this feels incorrect and ambiguous.

2. `No pinned chats` and `No recent chats` options are clickable and clicking on it takes you to a new conversation. should It be clickable? Ideally it should be just a text not a button but if it is a limitation today can we disable it?
Clickable_pinned_items.mov

Fixed

aprilma419 · 2025-11-25T11:15:59Z

To @karthikjeeyar 's point, agree that the empty states for the search results should be different from the normal ones.

Once users search with a keyword and no results are found, I think we only need one empty state message, such as “No results match your search.”

If either the pinned or recent section contains matching items, we show those results. For the section with no matches, we can still use the same empty state message.

See the example:

cc. @debsmita1

…ita1/rhdh-plugins into pr/debsmita1/1804

debsmita1 · 2025-11-25T18:12:29Z

To @karthikjeeyar 's point, agree that the empty states for the search results should be different from the normal ones.

Once users search with a keyword and no results are found, I think we only need one empty state message, such as “No results match your search.”

If either the pinned or recent section contains matching items, we show those results. For the section with no matches, we can still use the same empty state message.

See the example:

cc. @debsmita1

Updated

karthikjeeyar · 2025-11-26T05:03:38Z

@debsmita1 In case if both of the sections does not have results to show, then it should default empty state as April mentioned.

Right now, search empty state messages are pushed into the filteredConversation array so PF's default empty state never shown in the UI. If all the sections are empty then do not push them into the array, so that default empty state will start to show up.

sonarqubecloud · 2025-11-26T13:47:44Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.3% Duplication on New Code

See analysis details on SonarQube Cloud

debsmita1 · 2025-11-26T13:53:44Z

@debsmita1 In case if both of the sections does not have results to show, then it should default empty state as April mentioned.

Right now, search empty state messages are pushed into the filteredConversation array so PF's default empty state never shown in the UI. If all the sections are empty then do not push them into the array, so that default empty state will start to show up.

PTAL
https://github.com/user-attachments/assets/709b357d-a6ea-4b45-9bb0-a0ea47893bb4

HusneShabbir · 2025-11-27T03:57:30Z

/lgtm
It would be great if we could wait until this PR is merged.
Having it in would ensure that all the search combinations are validated on each CI check moving forward.

karthikjeeyar · 2025-11-27T06:34:50Z

Debsmita is not available to merge the e2e PR on her branch until next week, so I suggest let us merge this PR and @HusneShabbir can open a separate PR.

karthikjeeyar

/approve
/lgtm

* feat(lightspeed): chat history management * feat(lightspeed): chat history management * add tests for chat management * update the search empty state and add tests --------- Co-authored-by: HusneShabbir <husneshabbir447@gmail.com>

debsmita1 requested review from a team, karthikjeeyar and rohitkrai03 as code owners November 17, 2025 19:07

openshift-ci Bot added the do-not-merge/work-in-progress label Nov 17, 2025

debsmita1 force-pushed the lightspeed-chat-management branch 4 times, most recently from 73b798c to 0746ca7 Compare November 18, 2025 17:21

debsmita1 requested a review from yangcao77 as a code owner November 18, 2025 17:21

debsmita1 force-pushed the lightspeed-chat-management branch 7 times, most recently from 2a3ab1e to 4a97e5d Compare November 18, 2025 19:25

debsmita1 changed the title ~~[WIP] Lightspeed chat management~~ Lightspeed chat history management Nov 18, 2025

openshift-ci Bot removed the do-not-merge/work-in-progress label Nov 18, 2025

debsmita1 requested review from aprilma419 and christoph-jerolimov November 18, 2025 19:25

debsmita1 force-pushed the lightspeed-chat-management branch 2 times, most recently from 8ca5997 to c6ae552 Compare November 19, 2025 06:42

rohitkrai03 approved these changes Nov 19, 2025

View reviewed changes

openshift-ci Bot assigned rohitkrai03 Nov 19, 2025

openshift-ci Bot added the lgtm label Nov 19, 2025

HusneShabbir requested changes Nov 19, 2025

View reviewed changes

openshift-ci Bot removed the lgtm label Nov 21, 2025

debsmita1 force-pushed the lightspeed-chat-management branch from 87e3577 to acebff3 Compare November 24, 2025 11:45

HusneShabbir reviewed Nov 24, 2025

View reviewed changes

HusneShabbir self-requested a review November 25, 2025 09:26

karthikjeeyar reviewed Nov 25, 2025

View reviewed changes

Comment thread workspaces/lightspeed/plugins/lightspeed-common/src/permissions.ts

debsmita1 force-pushed the lightspeed-chat-management branch from b7a0edd to 9e60496 Compare November 25, 2025 10:31

openshift-ci Bot removed the lgtm label Nov 25, 2025

debsmita1 force-pushed the lightspeed-chat-management branch from 9e60496 to ca36712 Compare November 25, 2025 10:43

debsmita1 requested a review from karthikjeeyar November 25, 2025 10:44

Merge branch 'lightspeed-chat-management' of https://github.com/debsm…

bf4e9b1

…ita1/rhdh-plugins into pr/debsmita1/1804

debsmita1 force-pushed the lightspeed-chat-management branch from ca36712 to bf4e9b1 Compare November 25, 2025 18:11

update the search empty state and add tests

e7a39b7

openshift-ci Bot added the lgtm label Nov 27, 2025

karthikjeeyar approved these changes Nov 27, 2025

View reviewed changes

openshift-ci Bot assigned karthikjeeyar Nov 27, 2025

HusneShabbir approved these changes Nov 27, 2025

View reviewed changes

karthikjeeyar merged commit 58e26ba into redhat-developer:main Nov 27, 2025
10 checks passed

debsmita1 changed the title ~~Lightspeed chat history management~~ feat(lightspeed): chat history management Nov 27, 2025

rhdh-qodo-merge Bot mentioned this pull request Jul 10, 2026

feat(intelligent-assistant): Behavior-Linked Permissions Model - Intelligent Assistant for RHDH #3733

Merged

4 tasks

rhdh-qodo-merge Bot mentioned this pull request Jul 27, 2026

chore(global-header): Global header optimization #4006

Open

4 tasks

Uh oh!

Conversation

debsmita1 commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Hey, I just made a Pull Request!

✔️ Checklist

Uh oh!

rhdh-gh-app Bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changed Packages

Uh oh!

rohitkrai03 left a comment

Choose a reason for hiding this comment

Uh oh!

jrichter1 commented Nov 19, 2025

Uh oh!

HusneShabbir left a comment

Choose a reason for hiding this comment

Uh oh!

HusneShabbir left a comment

Choose a reason for hiding this comment

Uh oh!

aprilma419 commented Nov 25, 2025

Uh oh!

karthikjeeyar commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

debsmita1 commented Nov 25, 2025

Uh oh!

aprilma419 commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

debsmita1 commented Nov 25, 2025

Uh oh!

karthikjeeyar commented Nov 26, 2025

Uh oh!

sonarqubecloud Bot commented Nov 26, 2025

Quality Gate passed

Uh oh!

debsmita1 commented Nov 26, 2025

Uh oh!

HusneShabbir commented Nov 27, 2025

Uh oh!

karthikjeeyar commented Nov 27, 2025

Uh oh!

karthikjeeyar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

debsmita1 commented Nov 17, 2025 •

edited

Loading

rhdh-gh-app Bot commented Nov 17, 2025 •

edited

Loading

karthikjeeyar commented Nov 25, 2025 •

edited

Loading

aprilma419 commented Nov 25, 2025 •

edited

Loading