RHIDP-9710 Create aggregated metrics API for Scorecard backend plugin - #2020
Merged
imykhno merged 7 commits intoJan 12, 2026
Merged
Conversation
Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
imykhno
requested review from
a team,
Eswaraiahsapram,
christoph-jerolimov and
its-mitesh-kumar
as code owners
January 9, 2026 16:42
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Member
|
@imykhno can you add changeset? |
dzemanov
requested changes
Jan 12, 2026
Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
dzemanov
requested changes
Jan 12, 2026
…ecified Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
|
dzemanov
approved these changes
Jan 12, 2026
dzemanov
left a comment
dzemanov
left a comment
Member
There was a problem hiding this comment.
Tested that /metrics endpoint returns correctly metrics meta information without scorecard.read permission. Tested that filtering by metricIds and datasource works correctly. Tested you get 400 when you try to filter by both
elai-shalev
pushed a commit
to elai-shalev/rhdh-plugins
that referenced
this pull request
Jan 21, 2026
…redhat-developer#2020) * refactor(scorecard): add example entity Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * refactor(scorecard): metric and metrics aggregations endpoints Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * refactor(scorecard): remove unused `listMetricsByDatasource` method Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * fix(scorecard): aggregation documentation Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * fix(scorecard): the `/metrics` endpoint and update documentation Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * fix(scorecard): remove created RBAC role after all e2e tests Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * fix(scorecard): throw 400 if both `metricIds` and `datasource` are specified Signed-off-by: Ihor Mykhno <imykhno@redhat.com> --------- Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
elai-shalev
pushed a commit
to elai-shalev/rhdh-plugins
that referenced
this pull request
Jan 21, 2026
…redhat-developer#2020) * refactor(scorecard): add example entity Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * refactor(scorecard): metric and metrics aggregations endpoints Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * refactor(scorecard): remove unused `listMetricsByDatasource` method Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * fix(scorecard): aggregation documentation Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * fix(scorecard): the `/metrics` endpoint and update documentation Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * fix(scorecard): remove created RBAC role after all e2e tests Signed-off-by: Ihor Mykhno <imykhno@redhat.com> * fix(scorecard): throw 400 if both `metricIds` and `datasource` are specified Signed-off-by: Ihor Mykhno <imykhno@redhat.com> --------- Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Improvement aggregation logic after merge the #1984.
In this PR:
/metrics/:metricId/catalog/aggregationto/metrics/:metricId/catalog/aggregations. Ref - RHIDP-9710 Create aggregated metrics API for Scorecard backend plugin #1984 (comment)/metricsendpoint✔️ Checklist