Skip to content

fix(orchestrator): clarify ActiveText retrigger loading - #2096

Merged
mareklibra merged 2 commits into
redhat-developer:mainfrom
lokanandaprabhu:rhdhbugs-2507-activetext-loading
Jan 23, 2026
Merged

fix(orchestrator): clarify ActiveText retrigger loading#2096
mareklibra merged 2 commits into
redhat-developer:mainfrom
lokanandaprabhu:rhdhbugs-2507-activetext-loading

Conversation

@lokanandaprabhu

@lokanandaprabhu lokanandaprabhu commented Jan 16, 2026

Copy link
Copy Markdown
Member

Hey, I just made a Pull Request!

Fixes: https://issues.redhat.com/browse/RHDHBUGS-2507


  • show a spinner while fetch:retrigger dependencies are unresolved
image
  • keep spinner for actual fetch/evaluation
Screen.Recording.2026-01-16.at.2.00.53.PM.mov

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app

rhdh-gh-app Bot commented Jan 16, 2026

Copy link
Copy Markdown

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-orchestrator-form-widgets workspaces/orchestrator/plugins/orchestrator-form-widgets patch v1.6.1

@lokanandaprabhu
lokanandaprabhu force-pushed the rhdhbugs-2507-activetext-loading branch 2 times, most recently from 5cae79e to 7720544 Compare January 19, 2026 08:01
if (waitingForRetrigger) {
content = <CircularProgress size={16} />;
} else if (loading) {
content = <CircularProgress size={20} />;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The different sizes for spinners are intentional?

@mareklibra

Copy link
Copy Markdown
Member

One comment, otherwise lgtm

@lokanandaprabhu

Copy link
Copy Markdown
Member Author

@mareklibra ,

I set the smaller spinner (size={16}) for the “waiting for dependencies” state and the standard spinner (size={20}) for active fetch/evaluation. The idea was to visually distinguish “waiting on input” vs “fetch in progress.”

If you prefer consistency, I can make both sizes the same.

@mareklibra

Copy link
Copy Markdown
Member

Not sure the user will notice or understand :-)

What about keeping both of the same size. IF the user needs to know the reason, there can be a hint with text.

@lokanandaprabhu

Copy link
Copy Markdown
Member Author

Sure, for now I will keep the size same.

@lokanandaprabhu
lokanandaprabhu force-pushed the rhdhbugs-2507-activetext-loading branch from 7720544 to b9350eb Compare January 23, 2026 09:46
@sonarqubecloud

Copy link
Copy Markdown

@mareklibra
mareklibra merged commit 8fabecd into redhat-developer:main Jan 23, 2026
9 checks passed
@lokanandaprabhu

Copy link
Copy Markdown
Member Author

/cherrypick orchestrator-1.8

@openshift-cherrypick-robot

Copy link
Copy Markdown

@lokanandaprabhu: #2096 failed to apply on top of branch "orchestrator-1.8":

Applying: fix(orchestrator): clarify ActiveText retrigger loading
Using index info to reconstruct a base tree...
M	workspaces/orchestrator/plugins/orchestrator-form-widgets/src/utils/useFetchAndEvaluate.ts
M	workspaces/orchestrator/plugins/orchestrator-form-widgets/src/widgets/ActiveText.tsx
Falling back to patching base and 3-way merge...
Auto-merging workspaces/orchestrator/plugins/orchestrator-form-widgets/src/widgets/ActiveText.tsx
CONFLICT (content): Merge conflict in workspaces/orchestrator/plugins/orchestrator-form-widgets/src/widgets/ActiveText.tsx
Auto-merging workspaces/orchestrator/plugins/orchestrator-form-widgets/src/utils/useFetchAndEvaluate.ts
CONFLICT (content): Merge conflict in workspaces/orchestrator/plugins/orchestrator-form-widgets/src/utils/useFetchAndEvaluate.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix(orchestrator): clarify ActiveText retrigger loading

Details

In response to this:

/cherrypick orchestrator-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lokanandaprabhu added a commit to lokanandaprabhu/rhdh-plugins that referenced this pull request Jan 27, 2026
…oper#2096)

* fix(orchestrator): clarify ActiveText retrigger loading

* fix(orchestrator): align ActiveText spinner sizes
lokanandaprabhu added a commit that referenced this pull request Jan 27, 2026
* fix(orchestrator): clarify ActiveText retrigger loading

* fix(orchestrator): align ActiveText spinner sizes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants