fix(orchestrator): clarify ActiveText retrigger loading - #2096
Conversation
Changed Packages
|
5cae79e to
7720544
Compare
| if (waitingForRetrigger) { | ||
| content = <CircularProgress size={16} />; | ||
| } else if (loading) { | ||
| content = <CircularProgress size={20} />; |
There was a problem hiding this comment.
The different sizes for spinners are intentional?
|
One comment, otherwise lgtm |
|
I set the smaller spinner (size={16}) for the “waiting for dependencies” state and the standard spinner (size={20}) for active fetch/evaluation. The idea was to visually distinguish “waiting on input” vs “fetch in progress.” If you prefer consistency, I can make both sizes the same. |
|
Not sure the user will notice or understand :-) What about keeping both of the same size. IF the user needs to know the reason, there can be a hint with text. |
|
Sure, for now I will keep the size same. |
7720544 to
b9350eb
Compare
|
|
/cherrypick orchestrator-1.8 |
|
@lokanandaprabhu: #2096 failed to apply on top of branch "orchestrator-1.8": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…oper#2096) * fix(orchestrator): clarify ActiveText retrigger loading * fix(orchestrator): align ActiveText spinner sizes



Hey, I just made a Pull Request!
Fixes: https://issues.redhat.com/browse/RHDHBUGS-2507
Screen.Recording.2026-01-16.at.2.00.53.PM.mov
✔️ Checklist