Scorecard: Fix homepage aggregated scorecard widgets - #2201
Conversation
…se structure Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
Changed Packages
|
4add008 to
6d2a960
Compare
…ue or metric fetching fails Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
6d2a960 to
724cfd6
Compare
Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
…n failed cards Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
dzemanov
left a comment
There was a problem hiding this comment.
Thank you @imykhno, looks great.
I have verified permissions error works correctly.
I have verified aggregation with 0 entities / no metric data available:
User entity not found doesn't work correctly:
Can we make the text more responsive to fix this when switching languages?
|
Thank you @imykhno for this improvement! I have two questions:
|
Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
|
|
Following the previous review, I have implemented logic to display empty cards when the |
dzemanov
left a comment
There was a problem hiding this comment.
Thank you @imykhno.
I have confirmed that user not found error works correctly:

Rechecked error message is displayed in full when switching languages.

We will create a new issue to address #2201 (comment), cc @Eswaraiahsapram.
I would like to mention that the RHDHBUGS-2677 Bug to fix this behavior was created |






Hey, I just made a Pull Request!
Fix for RHDHBUGS-2554
Fix.RHDHBUGS-2554.mov
✔️ Checklist