[workspace/orchestrator] chore(release): fix typo that results in is_version_pr being falsely evaluated - #2469
Merged
Conversation
…evaluated Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
4 tasks
Review Summary by QodoFix variable reference typo in release workflow
WalkthroughsDescription• Fix typo in release workflow variable reference • Missing $ prefix caused PR_MERGED variable to be evaluated as literal string • Corrects conditional logic for version PR detection Diagramflowchart LR
A["Release Workflow"] -->|"Checks PR_MERGED variable"| B["Before: Literal 'PR_MERGED' string"]
A -->|"Fixed with $ prefix"| C["After: Actual variable value"]
B -->|"Always false"| D["Incorrect version PR detection"]
C -->|"Correct evaluation"| E["Proper version PR detection"]
File Changes1. .github/workflows/release_workspace_version.yml
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
hopehadfield
approved these changes
Mar 5, 2026
|
hopehadfield
merged commit Mar 5, 2026
11e7af8
into
redhat-developer:workspace/orchestrator
2 checks passed
hopehadfield
added a commit
to hopehadfield/rhdh-plugins
that referenced
this pull request
Mar 5, 2026
…evaluated (redhat-developer#2469) Signed-off-by: Hope Hadfield <hhadfiel@redhat.com> Co-authored-by: Hope Hadfield <hhadfiel@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2468
/assign hopehadfield