fix(scorecard): updated entities table header Metric to Status - #2650
Merged
christoph-jerolimov merged 1 commit intoMar 30, 2026
Merged
Conversation
Eswaraiahsapram
requested review from
a team,
christoph-jerolimov and
its-mitesh-kumar
as code owners
March 30, 2026 15:05
Review Summary by QodoUpdate scorecard entities table header from Metric to Status
WalkthroughsDescription• Updated scorecard entities table header from "Metric" to "Status" • Changed translation key across all language files (de, es, fr, it, ja) • Updated constants and test references to use new translation key • Updated API documentation to reflect translation key change Diagramflowchart LR
A["Translation Files<br/>de, es, fr, it, ja"] -- "Change key to<br/>header.status" --> B["Constants<br/>SCORECARD_ENTITIES_TABLE_HEADERS"]
B -- "Update label<br/>reference" --> C["Table Header<br/>Display"]
D["Test Files"] -- "Update assertions<br/>to new key" --> C
E["API Documentation"] -- "Reflect key<br/>change" --> F["report.api.md<br/>report-alpha.api.md"]
File Changes1. workspaces/scorecard/plugins/scorecard/src/translations/de.ts
|
Code Review by Qodo
1. Patch includes breaking API
|
Changed Packages
|
|
![rhdh-qodo-merge[bot]](https://avatars.githubusercontent.com/in/1961108?s=60&v=4){kind=small}
Comment on lines
84
to
87
| readonly 'entitiesPage.entitiesTable.header.owner': string; | ||
| readonly 'entitiesPage.entitiesTable.header.metric': string; | ||
| readonly 'entitiesPage.entitiesTable.header.lastUpdated': string; | ||
| readonly 'entitiesPage.entitiesTable.header.status': string; | ||
| readonly 'entitiesPage.entitiesTable.header.value': string; |
There was a problem hiding this comment.
1. Patch includes breaking api 🐞 Bug ⚙ Maintainability
This PR removes the public translation key entitiesPage.entitiesTable.header.metric from the exported scorecardTranslationRef and replaces it with ...header.status, which is a breaking change for downstream TypeScript consumers. The changeset marks this as a patch release, which can cause unexpected compile failures for consumers upgrading within 2.x.
Agent Prompt
### Issue description
The PR renames a `@public` translation key (`entitiesPage.entitiesTable.header.metric` -> `entitiesPage.entitiesTable.header.status`) on the exported `scorecardTranslationRef`, which is a breaking public API change. The accompanying changeset marks the release as `patch`, which violates semver expectations for a 2.x published package.
### Issue Context
Because `scorecardTranslationRef` is exported from the package entrypoint and its keys are part of the generated public API report, removing an existing key can break downstream TypeScript builds (custom translations / consumers referencing the old key).
### Fix options
Choose **one**:
1) **Preferred (keep patch + avoid breaking):** keep the old key for compatibility (either keep using it, or add it back as an alias).
- Add back `entitiesPage.entitiesTable.header.metric` (mapped to "Status") in `ref.ts` and in each locale file (de/es/fr/it/ja) so both keys exist.
- Optionally keep the UI using the new `...header.status` key.
2) **If you intend to break consumers:** change the changeset bump to **major** (since package is 2.x) to reflect the breaking API change.
### Fix Focus Areas
- workspaces/scorecard/plugins/scorecard/src/translations/ref.ts[104-133]
- workspaces/scorecard/plugins/scorecard/src/translations/de.ts[95-115]
- workspaces/scorecard/plugins/scorecard/src/translations/es.ts[95-115]
- workspaces/scorecard/plugins/scorecard/src/translations/fr.ts[95-115]
- workspaces/scorecard/plugins/scorecard/src/translations/it.ts[95-115]
- workspaces/scorecard/plugins/scorecard/src/translations/ja.ts[95-115]
- workspaces/scorecard/.changeset/large-grapes-appear.md[1-5]
- workspaces/scorecard/plugins/scorecard/report.api.md[80-90]
- workspaces/scorecard/plugins/scorecard/report-alpha.api.md[188-195]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
christoph-jerolimov
approved these changes
Mar 30, 2026
christoph-jerolimov
left a comment
christoph-jerolimov
left a comment
Member
There was a problem hiding this comment.
Lgtm! Thanks @Eswaraiahsapram
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fix
Description
Screenshots
✔️ Checklist