chore(extensions): update backstage version to 1.49.2 - #2672
Conversation
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Review Summary by QodoBump Backstage version to 1.49.2 across extensions workspace
WalkthroughsDescription• Update Backstage version from 1.45.2 to 1.49.2 • Bump all Backstage dependencies across extensions workspace • Update CLI and tooling packages to latest compatible versions • Add changeset documenting version bump for all extension packages Diagramflowchart LR
A["Backstage v1.45.2"] -- "version bump" --> B["Backstage v1.49.2"]
B -- "updates" --> C["CLI & Tooling"]
B -- "updates" --> D["Frontend Packages"]
B -- "updates" --> E["Backend Packages"]
B -- "updates" --> F["Plugin Packages"]
G["Changeset"] -- "documents" --> B
File Changes1. workspaces/extensions/.changeset/version-bump-1-49-2.md
|
Code Review by Qodo
1. Two catalog plugin majors
|
| "@backstage-community/plugin-rbac": "^1.45.0", | ||
| "@backstage/app-defaults": "^1.7.2", | ||
| "@backstage/catalog-model": "^1.7.6", | ||
| "@backstage/cli": "^0.34.5", | ||
| "@backstage/core-app-api": "^1.19.2", | ||
| "@backstage/core-components": "^0.18.3", | ||
| "@backstage/core-plugin-api": "^1.12.0", | ||
| "@backstage/integration-react": "^1.2.12", | ||
| "@backstage/plugin-api-docs": "^0.13.1", | ||
| "@backstage/plugin-catalog": "^1.32.0", | ||
| "@backstage/plugin-catalog-common": "^1.1.7", | ||
| "@backstage/plugin-catalog-graph": "^0.5.3", | ||
| "@backstage/plugin-catalog-import": "^0.13.7", | ||
| "@backstage/plugin-catalog-react": "^1.21.3", | ||
| "@backstage/plugin-kubernetes": "^0.12.13", | ||
| "@backstage/plugin-org": "^0.6.46", | ||
| "@backstage/plugin-permission-react": "^0.4.38", | ||
| "@backstage/plugin-scaffolder": "^1.34.3", | ||
| "@backstage/plugin-search": "^1.5.0", | ||
| "@backstage/plugin-search-react": "^1.10.0", | ||
| "@backstage/plugin-techdocs": "^1.16.0", | ||
| "@backstage/plugin-techdocs-module-addons-contrib": "^1.1.30", | ||
| "@backstage/plugin-techdocs-react": "^1.3.5", | ||
| "@backstage/plugin-user-settings": "^0.8.29", | ||
| "@backstage/theme": "^0.7.0", | ||
| "@backstage/ui": "^0.9.1", | ||
| "@backstage/app-defaults": "^1.7.6", | ||
| "@backstage/catalog-model": "^1.7.7", | ||
| "@backstage/cli": "^0.36.0", | ||
| "@backstage/core-app-api": "^1.19.6", | ||
| "@backstage/core-components": "^0.18.8", | ||
| "@backstage/core-plugin-api": "^1.12.4", | ||
| "@backstage/integration-react": "^1.2.16", | ||
| "@backstage/plugin-api-docs": "^0.13.5", | ||
| "@backstage/plugin-catalog": "^2.0.1", | ||
| "@backstage/plugin-catalog-common": "^1.1.8", | ||
| "@backstage/plugin-catalog-graph": "^0.6.0", | ||
| "@backstage/plugin-catalog-import": "^0.13.11", | ||
| "@backstage/plugin-catalog-react": "^2.1.0", |
There was a problem hiding this comment.
1. Two catalog plugin majors 🐞 Bug ≡ Correctness
app-legacy now depends on @backstage/plugin-catalog ^2.0.1 while also using @backstage-community/plugin-rbac ^1.45.0, which depends on @backstage/plugin-catalog ^1.31.2, resulting in both @backstage/plugin-catalog@1.33.1 and @backstage/plugin-catalog@2.0.1 being installed. Multiple copies of a Backstage plugin package break singleton identities (e.g., RouteRefs/plugin instances), which can cause RBAC UI navigation/linking to catalog routes to malfunction at runtime.
Agent Prompt
### Issue description
`app-legacy` was upgraded to `@backstage/plugin-catalog@^2`, but `@backstage-community/plugin-rbac@^1.45.0` still pulls `@backstage/plugin-catalog@^1.x`, leading to two installed majors of `@backstage/plugin-catalog`.
### Issue Context
Backstage plugin packages rely on singleton identities (RouteRefs/plugin instances). Installing two majors of the same plugin package commonly results in route bindings and navigation using different singleton instances.
### Fix Focus Areas
- workspaces/extensions/packages/app-legacy/package.json[21-37]
- workspaces/extensions/yarn.lock[1442-1454]
- workspaces/extensions/yarn.lock[3238-3287]
### What to change
- Upgrade `@backstage-community/plugin-rbac` to a version compatible with `@backstage/plugin-catalog@^2` (i.e., whose dependency/peerDependency range no longer pulls `@backstage/plugin-catalog@^1`).
- Re-run the workspace install to update `workspaces/extensions/yarn.lock`, and verify it no longer contains a separate `@backstage/plugin-catalog@npm:^1.x` entry.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
31961e3 to
b60d850
Compare
christoph-jerolimov
left a comment
There was a problem hiding this comment.
What @debsmita1 says. Please revert also every new : any code and this AnyQueryResult and AnyMutationResult
debsmita1
left a comment
There was a problem hiding this comment.
@ciiay Please check all the places where you had to change the types to get rid of the TS errors. If removing the types still results in errors even after updating the TS version, then please go ahead and create a bug so we can revisit it later and merge this PR for now.
christoph-jerolimov
left a comment
There was a problem hiding this comment.
Hi @ciiay, thanks, I still see some left overs from the initial change.
@ciiay @debsmita1, I see also plugin code changes that requires a deeper testing, its feels like a bit more than "just" a version bump, which is maybe needed, but requires manual testing imo.
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
b9d2c24 to
11e19da
Compare
Signed-off-by: Yi Cai <yicai@redhat.com>
|
Debsmita and my change requests was almost similar, so I hope its fine if I dismiss this to merge it today. Debsmita, feel free to let Yi and me know if you find more issues.
…er#2672) * chore(extensions): update backstage version to 1.49.2 Signed-off-by: Yi Cai <yicai@redhat.com> * resolved tsc erros Signed-off-by: Yi Cai <yicai@redhat.com> * fixed yarn build:api-reports issue Signed-off-by: Yi Cai <yicai@redhat.com> * fix failed e2e tests Signed-off-by: Yi Cai <yicai@redhat.com> * resolved a review comment Signed-off-by: Yi Cai <yicai@redhat.com> * addressed review comments Signed-off-by: Yi Cai <yicai@redhat.com> * reverted extra type changes Signed-off-by: Yi Cai <yicai@redhat.com> --------- Signed-off-by: Yi Cai <yicai@redhat.com>



Hey, I just made a Pull Request!
For RHIDP-12847
✔️ Checklist