fix(lightspeed): improve notebook upload modal and document overwrite UX - #2936
Conversation
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Changed Packages
|
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
There was a problem hiding this comment.
After uploading 10 documents, if I click on Add button it doesn't let me upload more files, did we have some number of documents limit in notebooks?
I understand we shouldn't upload more than 10 files at a time, but I thought we could repeat the process to add more documents if needed. @ShiranHi wdyt?
let's say even if we dont want to upload more than 10 documents in a notebook for some reason, I think this modal needs to be conveying the right message.
@karthikjeeyar Currently we have restricted to 25MB*10 files. I think we have limit of 250 MB per notebook. |
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
75786da to
9442245
Compare
|
@karthikjeeyar Disabled Add Button when no of files crosses 10. Screen.Recording.2026-04-28.at.4.02.25.PM.mov |
|
Great work on this @its-mitesh-kumar . I have a few suggestions to refine the UI. Let me know which of these you can include now and which we should move to a separate task to avoid delaying this merge.
A. Let's align the text to be like in the prototype. Use chips for the file types and remove the "(0)" from the button if no files added yet (keep it for when files added). B. The X button should not be red
The disable button looks good to me. |
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
|
@karthikjeeyar ! Handling duplicates file. Screen.Recording.2026-04-28.at.4.43.42.PM.mov |
|
@ShiranHi ! Could you please verify whether your comments align with the Figma design: https://www.figma.com/design/urwU8VqRvHfbxMqxeVknrv/RHDH-Lightspeed---AI-Assistant?node-id=3425-19685&m=dev. |
Yes, that works for me. We’ve made some progress on the UI improvements, and moving the remaining items to a follow-up ticket is the right approach. |
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
|
karthikjeeyar
left a comment
There was a problem hiding this comment.
All remaining UX alignment points needs to be covered in a followup ticket.
/approve
/lgtm
… UX (redhat-developer#2936) * fix(lightspeed): improve notebook upload modal and MessageBar UX Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * toast message auto dismiss Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * fix(lightspeed): fix overwrite flow Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * updating changeset Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * showing model from app-config for displaying response Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * disabling upload when 10 files are there Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * updating changeset Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * hadnling duplicates file Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * updating api report Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> --------- Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>













Description
Fixed
UI after changes
Screen.Recording.2026-04-28.at.1.mp4
Screen.Recording.2026-04-28.at.12.13.45.PM.mov
✔️ Checklist