Skip to content

fix(lightspeed): improve notebook upload modal and document overwrite UX - #2936

Merged
karthikjeeyar merged 9 commits into
redhat-developer:mainfrom
its-mitesh-kumar:fix/overwrite-documents
Apr 29, 2026
Merged

fix(lightspeed): improve notebook upload modal and document overwrite UX#2936
karthikjeeyar merged 9 commits into
redhat-developer:mainfrom
its-mitesh-kumar:fix/overwrite-documents

Conversation

@its-mitesh-kumar

@its-mitesh-kumar its-mitesh-kumar commented Apr 28, 2026

Copy link
Copy Markdown
Member

Description

  • Fix overwrite flow so that clicking "Overwrite" in the confirmation modal adds duplicate files to the Add Document modal instead of uploading them immediately
  • Reduce notebook delete toast auto-dismiss timeout from 8 seconds to 2 seconds for better UX
  • Fixing Modal Name in the response.
  • Fixed the Add Document modal auto-closing on upload, now allows batch file selection from multiple folders
  • MessageBar is now disabled when no documents are uploaded, with a tooltip explaining the requirement
  • Document Upload toast message auto dismissed.

Fixed

UI after changes

Screen.Recording.2026-04-28.at.1.mp4
Screen.Recording.2026-04-28.at.12.13.45.PM.mov

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@rhdh-gh-app

rhdh-gh-app Bot commented Apr 28, 2026

Copy link
Copy Markdown

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed patch v2.5.0

@its-mitesh-kumar its-mitesh-kumar changed the title Fix/overwrite documents fix(lightspeed): improve notebook upload modal and document overwrite UX Apr 28, 2026
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

@karthikjeeyar karthikjeeyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After uploading 10 documents, if I click on Add button it doesn't let me upload more files, did we have some number of documents limit in notebooks?

I understand we shouldn't upload more than 10 files at a time, but I thought we could repeat the process to add more documents if needed. @ShiranHi wdyt?

let's say even if we dont want to upload more than 10 documents in a notebook for some reason, I think this modal needs to be conveying the right message.

image

@its-mitesh-kumar

its-mitesh-kumar commented Apr 28, 2026

Copy link
Copy Markdown
Member Author

shouldn't upload more than 10 files at a time, but I thought we could repeat the process to add more documents if needed. @ShiranHi wdyt?

@karthikjeeyar Currently we have restricted to 25MB*10 files. I think we have limit of 250 MB per notebook.
If while selecting files if number crosses 10 we show the error like this.
For notebook having more than 10 documents we can disable Add button to restrict upload document and show tooltip Maximum 10 documents are allowed, delete a document to upload new document.
Screenshot 2026-04-28 at 2 36 02 PM

Comment thread workspaces/lightspeed/.changeset/notebook-upload-modal-ux.md Outdated
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@its-mitesh-kumar
its-mitesh-kumar force-pushed the fix/overwrite-documents branch from 75786da to 9442245 Compare April 28, 2026 10:38
@its-mitesh-kumar

Copy link
Copy Markdown
Member Author

@karthikjeeyar Disabled Add Button when no of files crosses 10.

Screen.Recording.2026-04-28.at.4.02.25.PM.mov

@ShiranHi

ShiranHi commented Apr 28, 2026

Copy link
Copy Markdown

Great work on this @its-mitesh-kumar . I have a few suggestions to refine the UI. Let me know which of these you can include now and which we should move to a separate task to avoid delaying this merge.

  1. Notebook card: please align the text and the icon. Also, if there is one resource uploaded write "1 document" (singular). If no resources added please write "No documents" instead of "0 documents".
image01
  1. The background should be white for both the Notebook and the Chat main conversation area
image02
  1. Please add icons to the notebook menu:
image07
  1. Please use the + icon to be located on the left side of the "Add" button and use the plus icon we have in the side panel also in the "Add a resource" button
image03
  1. Chat field should be disabled when no resources added, I saw the tooltip but the field seems active.

  2. Upload modal:

A. Let's align the text to be like in the prototype. Use chips for the file types and remove the "(0)" from the button if no files added yet (keep it for when files added).
image04

B. The X button should not be red
image05

  1. Please remove the floating alerts when uploading a file if the upload is success users can see the files in the side panel.
image06
  1. After adding files please add a loading state like we have in the prototype.

  2. Can all the rename of a resource and a notebook be inline with a double click (like in the prototype) instead of a modal?

image08
  1. Overwrite files, can we prevent from modal on top of modal in this case? We have another solution in the prototype.
image09

I understand we shouldn't upload more than 10 files at a time, but I thought we could repeat the process to add more documents if needed. @ShiranHi wdyt?

The disable button looks good to me.

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@its-mitesh-kumar

Copy link
Copy Markdown
Member Author

@karthikjeeyar ! Handling duplicates file.

Screen.Recording.2026-04-28.at.4.43.42.PM.mov

@its-mitesh-kumar

Copy link
Copy Markdown
Member Author

@ShiranHi ! Could you please verify whether your comments align with the Figma design: https://www.figma.com/design/urwU8VqRvHfbxMqxeVknrv/RHDH-Lightspeed---AI-Assistant?node-id=3425-19685&m=dev.
If you’re suggesting any changes or improvements, we’ll need to create a separate UX improvement story for that.

@ShiranHi

Copy link
Copy Markdown

@ShiranHi ! Could you please verify whether your comments align with the Figma design: https://www.figma.com/design/urwU8VqRvHfbxMqxeVknrv/RHDH-Lightspeed---AI-Assistant?node-id=3425-19685&m=dev. If you’re suggesting any changes or improvements, we’ll need to create a separate UX improvement story for that.

Yes, that works for me. We’ve made some progress on the UI improvements, and moving the remaining items to a follow-up ticket is the right approach.

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

@karthikjeeyar karthikjeeyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All remaining UX alignment points needs to be covered in a followup ticket.

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Apr 29, 2026
@karthikjeeyar
karthikjeeyar merged commit d621f93 into redhat-developer:main Apr 29, 2026
12 checks passed
lokanandaprabhu pushed a commit to lokanandaprabhu/rhdh-plugins that referenced this pull request May 14, 2026
… UX (redhat-developer#2936)

* fix(lightspeed): improve notebook upload modal and MessageBar UX

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

* toast message auto dismiss

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

* fix(lightspeed): fix overwrite flow

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

* updating changeset

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

* showing model from app-config for displaying response

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

* disabling upload when 10 files are there

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

* updating changeset

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

* hadnling duplicates file

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

* updating api report

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

---------

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@rhdh-qodo-merge rhdh-qodo-merge Bot mentioned this pull request Aug 5, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants