fix(lightspeed): show mcp settings only visible in chat tab - #2998
Merged
its-mitesh-kumar merged 2 commits intoMay 5, 2026
Merged
Conversation
ciiay
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
May 5, 2026 05:06
Changed Packages
|
ciiay
force-pushed
the
rhdhbugs-3043-fix-mcp-settings-display-logic
branch
from
May 5, 2026 05:07
cb12a6c to
efa63d9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2998 +/- ##
==========================================
+ Coverage 60.74% 60.78% +0.03%
==========================================
Files 2067 2067
Lines 63800 63873 +73
Branches 16635 16664 +29
==========================================
+ Hits 38758 38826 +68
- Misses 24769 24774 +5
Partials 273 273
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
|
@ciiay |
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay
force-pushed
the
rhdhbugs-3043-fix-mcp-settings-display-logic
branch
from
May 5, 2026 16:13
b1fdee2 to
b12f312
Compare
|
its-mitesh-kumar
approved these changes
May 5, 2026
its-mitesh-kumar
left a comment
its-mitesh-kumar
left a comment
Member
There was a problem hiding this comment.
Working as per expected.
/lgtm
Screen.Recording.2026-05-05.at.10.15.05.PM.mov
its-mitesh-kumar
changed the title
lokanandaprabhu
pushed a commit
to lokanandaprabhu/rhdh-plugins
that referenced
this pull request
May 14, 2026
…eveloper#2998) * fix(lightspeed): keep Chat/Notebooks tab across display modes Signed-off-by: Yi Cai <yicai@redhat.com> * addressed review comments Signed-off-by: Yi Cai <yicai@redhat.com> --------- Signed-off-by: Yi Cai <yicai@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
For RHDHBUGS-3043, RHDHBUGS-3054 and RHDHBUGS-3071
✔️ Checklist
screen recording (updated on 5/5)
rhdhbugs_3043.mp4
Test steps:
Please follow steps on PR description of #2754