Security: Sanitize Lightspeed Core error responses - #3296
Merged
Jdubrick merged 4 commits intoJun 8, 2026
Merged
Conversation
rajin-kichannagari
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
June 4, 2026 18:34
Changed Packages
|
Jdubrick
reviewed
Jun 4, 2026
Jdubrick
left a comment
Jdubrick
left a comment
Contributor
There was a problem hiding this comment.
1 small comment, rest looks good
Contributor
|
/ok-to-test |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3296 +/- ##
=======================================
Coverage 53.98% 53.98%
=======================================
Files 2401 2402 +1
Lines 87397 87397
Branches 24196 24195 -1
=======================================
+ Hits 47179 47182 +3
+ Misses 38670 38667 -3
Partials 1548 1548
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
JslYoon
requested changes
Jun 4, 2026
JslYoon
left a comment
JslYoon
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, although the sanitizeLcsError() function uses any for both errorBody and logger
parameters. We should add proper TypeScript types:
- logger should use the LoggerService type (already imported in types.ts from
@backstage/backend-plugin-api). - errorBody should have an interface that matches the LCS error response
structure (see the test mocks for examples of the shape). - for the function sanitizeLcsError lets capitalize the LCS bit.
If you can also address the SonarCloud analysis and failing CI after rebasing, I can take another look.
Jdubrick
reviewed
Jun 5, 2026
4 tasks
JslYoon
approved these changes
Jun 8, 2026
JslYoon
left a comment
JslYoon
left a comment
Contributor
There was a problem hiding this comment.
lgtm, make sure all other comments are address too before merging
added 4 commits
June 8, 2026 13:53
Fixes information disclosure vulnerability where LCS error details were being forwarded directly to clients. Changes: - Add sanitizeLcsError() function to sanitize error responses - Update 4 endpoints to use sanitization - Enhance tests to verify internal details are not exposed
- Move sanitizeLCSError to utils.ts for reusability - Fix TypeScript types (use LoggerService, add LCSErrorResponse interface) - Capitalize LCS in function name - Fix failing test for conversation not found - Add unit tests for utils to improve coverage
Extract duplicated error handling pattern into a reusable helper function. This reduces duplication from 5.6% to under 3%.
- Add try/catch to handle cases where LCS doesn't return JSON - Type the response parameter properly instead of using any - Add tests for both JSON and non-JSON error responses
rajin-kichannagari
force-pushed
the
fix/sanitize-lcs-error-responses
branch
from
June 8, 2026 17:53
3fbd276 to
54d8a44
Compare
|
Contributor
|
/lgtm |
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes an information disclosure vulnerability where error responses from Lightspeed Core were leaking internal details to clients.
The issue:
When LCS returns errors, we were forwarding the full error message to clients, which could include model names, provider info, org IDs, stack traces, etc. Not great for security.
What I changed:
sanitizeLcsError()function that logs the full error server-side but only returns a generic message to the client/v1/feedback,/v1/query/interrupt,/v1/query, and/v2/conversations/:idExample:
Before:
{"error": "Error from lightspeed-core server: Model gpt-4-0613 failed with OpenAI API error: rate limit exceeded for organization org-abc123"}After:
{"error": "Error from lightspeed-core server while processing query"}Full error details are still logged on the server for debugging.
✔️ Checklist