Skip to content

chore: remove broken postinstall scripts #3909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonkoops wants to merge 1 commit into from
Closed

chore: remove broken postinstall scripts #3909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,12 @@
node-version: ${{ matrix.node-version }}
registry-url: https://registry.npmjs.org/ # Needed for auth

- name: Install root dependencies

@fullsend-ai-review fullsend-ai-review Bot Jul 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] protected-path

Files under .github/ are protected paths requiring human approval. This PR modifies .github/workflows/ci.yml and .github/workflows/coverage-baseline.yml without a linked issue providing authorization context. The changes add an 'Install root dependencies' step to compensate for removing workspace postinstall hooks and appear functionally correct. Human approval is always required for protected-path changes.

Suggested fix: Ensure a maintainer reviews the CI workflow changes. Consider linking an issue to provide authorization context for the protected-path modifications.

run: yarn install --immutable
working-directory: ${{ github.workspace }}

- name: yarn install
run: yarn install --immutable

Check warning on line 85 in .github/workflows/ci.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Lifecycle scripts are enabled by default in Yarn v2+. 


See more on https://sonarcloud.io/project/issues?id=redhat-developer_rhdh-plugins&issues=AZ-FoHu8HEKP2PtfpFP9&open=AZ-FoHu8HEKP2PtfpFP9&pullRequest=3909

- name: check for missing repo fixes
run: yarn fix --check
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/coverage-baseline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,12 @@
node-version: 24
registry-url: https://registry.npmjs.org/

- name: Install root dependencies
run: yarn install --immutable
working-directory: ${{ github.workspace }}

- name: Install dependencies
run: yarn install --immutable

Check warning on line 80 in .github/workflows/coverage-baseline.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Lifecycle scripts are enabled by default in Yarn v2+. 


See more on https://sonarcloud.io/project/issues?id=redhat-developer_rhdh-plugins&issues=AZ-FoH9GHEKP2PtfpFP-&open=AZ-FoH9GHEKP2PtfpFP-&pullRequest=3909

- name: Install jest-junit reporter
env:
Expand Down
3 changes: 1 addition & 2 deletions workspaces/adoption-insights/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": {
"packages": [
Expand Down
3 changes: 1 addition & 2 deletions workspaces/ai-integrations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"lint": "backstage-cli repo lint --since origin/main",
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": {
"packages": [
Expand Down
3 changes: 1 addition & 2 deletions workspaces/app-defaults/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"lint:all": "backstage-cli repo lint",
"prettier:fix": "prettier --write .",
"prettier:check": "prettier --check .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": [
"packages/*",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/augment/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"prettier:fix": "prettier --write .",
"chores": "yarn prettier:fix && yarn lint:all --fix && yarn tsc:full && yarn build:api-reports && yarn test:all",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "node scripts/patch-agents-core.js && cd ../../ && yarn install"
"postinstall": "node scripts/patch-agents-core.js"
},
"workspaces": {
"packages": [
Expand Down
3 changes: 1 addition & 2 deletions workspaces/boost/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"prettier:fix": "prettier --write .",
"chores": "yarn prettier:fix && yarn lint:all --fix && yarn tsc:full && yarn build:api-reports && yarn openspec:validate && yarn test:all",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"openspec:validate": "openspec validate --all --json",
"postinstall": "cd ../../ && yarn install"
"openspec:validate": "openspec validate --all --json"
},
"workspaces": {
"packages": [
Expand Down
1 change: 0 additions & 1 deletion workspaces/bulk-import/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install",
"test:e2e:legacy": "APP_MODE=legacy playwright test",
"test:e2e:nfs": "APP_MODE=nfs playwright test",
"test:e2e:all": "yarn test:e2e:legacy && yarn test:e2e:nfs",
Expand Down
3 changes: 1 addition & 2 deletions workspaces/cost-management/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": {
"packages": [
Expand Down
1 change: 0 additions & 1 deletion workspaces/dcm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install",
"e2e-test": "playwright test",
"e2e-test:live": "playwright test --project=live"
},
Expand Down
3 changes: 1 addition & 2 deletions workspaces/extensions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": {
"packages": [
Expand Down
3 changes: 1 addition & 2 deletions workspaces/global-header/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": {
"packages": [
Expand Down
3 changes: 1 addition & 2 deletions workspaces/homepage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
"playwright": "bash -c 'if [[ \"$*\" == \"test\" ]]; then yarn test:e2e:all; else npx playwright \"$@\"; fi' _",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": {
"packages": [
Expand Down
3 changes: 1 addition & 2 deletions workspaces/install-dynamic-plugins/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"prettier": "@spotify/prettier-config",
"lint-staged": {
Expand Down
3 changes: 1 addition & 2 deletions workspaces/intelligent-assistant/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
"lint:fix": "backstage-cli package lint --fix",
"prettier:check": "prettier --ignore-unknown --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": [
"packages/*",
Expand Down
3 changes: 1 addition & 2 deletions workspaces/konflux/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": {
"packages": [
Expand Down
3 changes: 1 addition & 2 deletions workspaces/mcp-integrations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
"lint": "backstage-cli repo lint --since origin/main",
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": {
"packages": [
Expand Down
1 change: 0 additions & 1 deletion workspaces/noop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"build:api-reports:only": "exit 0",
"build:knip-reports": "exit 0",
"fix": "exit 0",
"postinstall": "cd ../../ && yarn install",
"prettier:check": "exit 0",
"tsc:full": "exit 0",
"test:all": "exit 0"
Expand Down
1 change: 0 additions & 1 deletion workspaces/orchestrator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "./scripts/postinstall",
"enable-in-rhdh-repo": "node scripts/export-to-rhdh-repo.js && node scripts/update-config-in-rhdh-repo.js"
},
"workspaces": {
Expand Down
6 changes: 0 additions & 6 deletions workspaces/orchestrator/scripts/postinstall
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion workspaces/quickstart/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install",
"test:e2e": "yarn test:e2e:all",
"test:e2e:legacy": "APP_MODE=legacy playwright test",
"test:e2e:nfs": "APP_MODE=nfs playwright test",
Expand Down
3 changes: 1 addition & 2 deletions workspaces/repo-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"new": "backstage-cli new --scope internal",
"build:api-reports": "yarn build:api-reports:only --tsc",
"build:api-reports:only": "backstage-repo-tools api-reports -o ae-wrong-input-file-type --validate-release-tags",
"build:knip-reports": "backstage-repo-tools knip-reports",
"postinstall": "cd ../../ && yarn install"
"build:knip-reports": "backstage-repo-tools knip-reports"
},
"prettier": "@spotify/prettier-config",
"lint-staged": {
Expand Down
3 changes: 1 addition & 2 deletions workspaces/repo-tools/packages/cli/src/lib/workspaces/templates/workspace/package.json.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": [
"packages/*",
Expand Down
3 changes: 1 addition & 2 deletions workspaces/scorecard/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": {
"packages": [
Expand Down
3 changes: 1 addition & 2 deletions workspaces/theme/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope red-hat-developer-hub"
},
"workspaces": [
"packages/*",
Expand Down
3 changes: 1 addition & 2 deletions workspaces/translations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
"lint:all": "backstage-cli repo lint",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"new": "backstage-cli new --scope red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope red-hat-developer-hub"
},
"workspaces": {
"packages": [
Expand Down
3 changes: 1 addition & 2 deletions workspaces/x2a/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"chores": "yarn prettier:fix && yarn lint:all --fix && yarn tsc:full && yarn build:api-reports && yarn test:all:pg",
"new": "backstage-cli new --scope @red-hat-developer-hub",
"postinstall": "cd ../../ && yarn install"
"new": "backstage-cli new --scope @red-hat-developer-hub"
},
"workspaces": {
"packages": [
Expand Down
Loading