fix(quickstart): make Quick start help menu item clickable - #4021
Conversation
Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3489 Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Changed Packages
|
PR Summary by QodoFix Quick start help menu item clickability in global-header dropdown
AI Description
Diagram
High-Level Assessment
Files changed (6)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4021 +/- ##
==========================================
- Coverage 57.80% 57.79% -0.01%
==========================================
Files 2393 2393
Lines 95919 95895 -24
Branches 26776 26776
==========================================
- Hits 55448 55426 -22
+ Misses 38935 38933 -2
Partials 1536 1536
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
/fs-review |
Code Review by Qodo
Context used✅ Compliance rules (platform):
11 rules✅ Cross-repo context Explored:
repo: redhat-developer/rhdh (sha: 6bcb0141) Not relevant to this PR:
redhat-developer/rhdh-chart Not relevant to this PR:
redhat-developer/rhdh-operator Not relevant to this PR:
redhat-developer/rhdh-local 1.
|
|
🤖 Finished Review · ✅ Success · Started 3:25 AM UTC · Completed 3:42 AM UTC |
ReviewFindingsLow
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
Pin global-header to 1.21.5 to match RHDH and avoid floating to 1.22.x. Use jest.clearAllMocks() for consistency with sibling tests. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Pin app-legacy to global-header 1.21.5 so the workspace lockfile no longer carries both 1.21.5 and 1.22.1. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
HusneShabbir
left a comment
HusneShabbir
left a comment
There was a problem hiding this comment.
/lgtm
Tested Locally, working as expected
rohitkrai03
left a comment
rohitkrai03
left a comment
There was a problem hiding this comment.
@ciiay shouldnt the fix be in global header component if it's not using on click handler properly?
…ementing
The root cause was GlobalHeaderMenuItem using component={Fragment} without
a `to` prop (fixed in global-header 1.21.1+). Keep using that shared API
and rely on the 1.21.5 dependency bump rather than a local MenuItem copy.
Signed-off-by: Yi Cai <yicai@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
debsmita1
left a comment
debsmita1
left a comment
There was a problem hiding this comment.
Tested this on RHDH locally in app-next
Before the changes
With the changes
/lgtm
…veloper#4021) * fix(quickstart): make Quick start help menu item clickable Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3489 Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> * fix(quickstart): align global-header pin and test mock reset Pin global-header to 1.21.5 to match RHDH and avoid floating to 1.22.x. Use jest.clearAllMocks() for consistency with sibling tests. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> * fix(quickstart): dedupe global-header to fix CI lockfile check Pin app-legacy to global-header 1.21.5 so the workspace lockfile no longer carries both 1.21.5 and 1.22.1. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> * fix(quickstart): consume fixed GlobalHeaderMenuItem instead of reimplementing The root cause was GlobalHeaderMenuItem using component={Fragment} without a `to` prop (fixed in global-header 1.21.1+). Keep using that shared API and rely on the 1.21.5 dependency bump rather than a local MenuItem copy. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> --------- Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…veloper#4021) * fix(quickstart): make Quick start help menu item clickable Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3489 Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> * fix(quickstart): align global-header pin and test mock reset Pin global-header to 1.21.5 to match RHDH and avoid floating to 1.22.x. Use jest.clearAllMocks() for consistency with sibling tests. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> * fix(quickstart): dedupe global-header to fix CI lockfile check Pin app-legacy to global-header 1.21.5 so the workspace lockfile no longer carries both 1.21.5 and 1.22.1. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> * fix(quickstart): consume fixed GlobalHeaderMenuItem instead of reimplementing The root cause was GlobalHeaderMenuItem using component={Fragment} without a `to` prop (fixed in global-header 1.21.1+). Keep using that shared API and rely on the 1.21.5 dependency bump rather than a local MenuItem copy. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> --------- Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
5 participants
Description
The Quick start item in the global-header help dropdown was visible but not clickable, so the drawer never opened. This change renders a real MUI
MenuItemviaforwardRef(instead ofGlobalHeaderMenuItemwithout atoprop, which usedcomponent={Fragment}in global-header 1.21.0 and dropped click handlers), bumps the global-header dependency, and adds unit coverage.Root cause
GlobalHeaderMenuItemwithout atoprop renderedMenuItem component={Fragment}in@red-hat-developer-hub/backstage-plugin-global-header@1.21.0, which discardedonClickandrole="menuitem".Fixed
UI before changes
UI after changes
Test Plan
yarn startinworkspaces/quickstart)refonReact.FragmentChecklist
Note
Made with Cursor