chore(RHIDP-14706): update archive script in rhdh-plugins - #4036
Conversation
References of the archived workspace are now automatically removed from the files: codecov.yml, .github/labeler.yml and .github/pr-labeler.yml Signed-off-by: Adam Brezina <breziinaadam@seznam.cz>
04kash
left a comment
There was a problem hiding this comment.
Nice! Just address the SonarCloud warning to "Use .indexOf() instead of .findIndex() when looking for the index of an item." and this should be good to merge.
Signed-off-by: Adam Brezina <breziinaadam@seznam.cz>
PR Summary by QodoUpdate archive script to remove workspace references from labeler and Codecov
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
11 rules✅ Cross-repo context Not relevant to this PR:
redhat-developer/rhdh Not relevant to this PR:
redhat-developer/rhdh-chart Not relevant to this PR:
redhat-developer/rhdh-operator Not relevant to this PR:
redhat-developer/rhdh-local 1.
|
Signed-off-by: Adam Brezina <breziinaadam@seznam.cz>
|
|
Qodo was right. The previously used argument in the indexOf() would silently fail the whole function. All should be good now. |
…eloper#4036) * chore(RHIDP-14706): update archive script in rhdh-plugins References of the archived workspace are now automatically removed from the files: codecov.yml, .github/labeler.yml and .github/pr-labeler.yml Signed-off-by: Adam Brezina <breziinaadam@seznam.cz> * changed findIndex() to indexOf() Signed-off-by: Adam Brezina <breziinaadam@seznam.cz> * fixed the bug Qodo was suggesting -> bad use of indexOf(). Signed-off-by: Adam Brezina <breziinaadam@seznam.cz> --------- Signed-off-by: Adam Brezina <breziinaadam@seznam.cz>



Jira ticket: https://redhat.atlassian.net/browse/RHIDP-14706
References of the archived workspace are now automatically removed from the files: codecov.yml, .github/labeler.yml and .github/pr-labeler.yml
Hey, I just made a Pull Request!
✔️ Checklist