-
Notifications
You must be signed in to change notification settings - Fork 115
feat(extensions): add catalog source filter and display to Extensions UI #4070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rohitratannagar
wants to merge
8
commits into
redhat-developer:main
Choose a base branch
from
rohitratannagar:feat/RHIDP-15617-catalog-source-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4d53696
feat(extensions): add catalog source filter and display to Extensions UI
rohitratannagar 9cddedb
chore(extensions): add changeset for catalog source filter feature
rohitratannagar 8689324
fix(extensions): provide configApiRef in ExtensionsPluginContent tests
rohitratannagar ee56aa0
fix(extensions): address PR review feedback
rohitratannagar 0aa990d
fix(extensions): resolve TypeScript errors in ExtensionsPluginContent…
rohitratannagar 86eaaf1
fix(extensions): use positive isExtensionsPlugin check and revert app…
rohitratannagar d8e3f74
feat(extensions): enhance plugin card and detail view UI
rohitratannagar 1e4186f
feat(extensions): style CatalogSourceBadge chip with filled background
rohitratannagar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@red-hat-developer-hub/backstage-plugin-extensions': minor | ||
| --- | ||
|
|
||
| Add catalog source filter and display to Extensions UI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Copyright Red Hat, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| export interface Config { | ||
| extensions?: { | ||
| /** | ||
| * Metadata for catalog sources used to label and filter plugins by origin. | ||
| * Keys correspond to the `extensions.backstage.io/catalog-source` annotation value. | ||
| * @visibility frontend | ||
| */ | ||
| catalogSources?: { | ||
| [sourceKey: string]: { | ||
| /** | ||
| * Display label for this catalog source. | ||
| * @visibility frontend | ||
| */ | ||
| label: string; | ||
|
|
||
| /** | ||
| * Optional description shown as a tooltip. | ||
| * @visibility frontend | ||
| */ | ||
| description?: string; | ||
|
|
||
| /** | ||
| * Optional badge text shown on the plugin card in list view. | ||
| * @visibility frontend | ||
| */ | ||
| badge?: string; | ||
| }; | ||
| }; | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
workspaces/extensions/plugins/extensions/src/components/CatalogSourceBadge.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* | ||
| * Copyright Red Hat, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import Chip from '@mui/material/Chip'; | ||
| import Tooltip from '@mui/material/Tooltip'; | ||
|
|
||
| import type { ExtensionsPlugin } from '@red-hat-developer-hub/backstage-plugin-extensions-common'; | ||
| import { ExtensionsAnnotation } from '@red-hat-developer-hub/backstage-plugin-extensions-common'; | ||
|
|
||
| import { | ||
| useCatalogSourceConfig, | ||
| getCatalogSourceLabel, | ||
| } from '../hooks/useCatalogSourceConfig'; | ||
|
|
||
| export const CatalogSourceBadge = ({ | ||
| plugin, | ||
| }: { | ||
| plugin: ExtensionsPlugin; | ||
| }) => { | ||
| const sourcesConfig = useCatalogSourceConfig(); | ||
| const sourceKey = | ||
| plugin.metadata?.annotations?.[ExtensionsAnnotation.CATALOG_SOURCE]; | ||
|
|
||
| if (!sourceKey) return null; | ||
|
|
||
| const meta = sourcesConfig[sourceKey]; | ||
| const badgeLabel = | ||
| meta?.badge ?? getCatalogSourceLabel(plugin, sourcesConfig); | ||
|
|
||
| const chip = ( | ||
| <Chip | ||
| label={badgeLabel} | ||
| size="small" | ||
| sx={{ | ||
| backgroundColor: 'action.hover', | ||
| fontWeight: 500, | ||
| fontSize: '0.75rem', | ||
| }} | ||
| /> | ||
| ); | ||
|
|
||
| if (meta?.description) { | ||
| return ( | ||
| <Tooltip title={meta.description} placement="right" arrow> | ||
| {chip} | ||
| </Tooltip> | ||
| ); | ||
| } | ||
|
|
||
| return chip; | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.