Skip to content

chore: sync orchestrator release-1.10 to workspace - #4100

Merged
lokanandaprabhu merged 2 commits into
workspace/orchestratorfrom
orchestrator/release-1.10
Jul 30, 2026
Merged

chore: sync orchestrator release-1.10 to workspace#4100
lokanandaprabhu merged 2 commits into
workspace/orchestratorfrom
orchestrator/release-1.10

Conversation

@lokanandaprabhu

Copy link
Copy Markdown
Member

Backport of #3665 to release 1.10

Original PR: #3665
Backport PR #1: #0

This PR triggers the Version Packages workflow.

Do not edit manually — auto-generated by backport skill.

alizard0 and others added 2 commits July 2, 2026 11:34
#4098)

Use a CSS grid two-column layout with minmax(0, 1fr) columns and constrain
metadata tables so workflow run cards no longer bleed into each other when
cardHeightMode is set to content.

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (workspace/orchestrator@eb6cce6). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             workspace/orchestrator    #4100   +/-   ##
=========================================================
  Coverage                          ?   59.57%           
=========================================================
  Files                             ?     2097           
  Lines                             ?    65234           
  Branches                          ?    16986           
=========================================================
  Hits                              ?    38862           
  Misses                            ?    25977           
  Partials                          ?      395           
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (?) Carriedforward from 04a8391
ai-integrations 70.03% <ø> (?) Carriedforward from 04a8391
app-defaults 69.60% <ø> (?) Carriedforward from 04a8391
augment 69.36% <ø> (?) Carriedforward from 04a8391
bulk-import 72.86% <ø> (?) Carriedforward from 04a8391
cost-management 16.49% <ø> (?) Carriedforward from 04a8391
dcm 32.85% <ø> (?) Carriedforward from 04a8391
extensions 61.79% <ø> (?) Carriedforward from 04a8391
global-floating-action-button 74.30% <ø> (?) Carriedforward from 04a8391
global-header 61.68% <ø> (?) Carriedforward from 04a8391
homepage 50.95% <ø> (?) Carriedforward from 04a8391
konflux 91.01% <ø> (?) Carriedforward from 04a8391
lightspeed 68.34% <ø> (?) Carriedforward from 04a8391
mcp-integrations 81.59% <ø> (?) Carriedforward from 04a8391
orchestrator 37.54% <0.00%> (?)
quickstart 62.64% <ø> (?) Carriedforward from 04a8391
sandbox 79.56% <ø> (?) Carriedforward from 04a8391
scorecard 83.58% <ø> (?) Carriedforward from 04a8391
theme 64.54% <ø> (?) Carriedforward from 04a8391
translations 8.49% <ø> (?) Carriedforward from 04a8391
x2a 57.33% <ø> (?) Carriedforward from 04a8391

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6cce6...95b5a82. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Fix workflow instance content-mode card overlap and bump form-data

🐞 Bug fix ⚙️ Configuration changes 🕐 20-40 Minutes

Grey Divider

AI Description

• Prevent workflow instance cards overlapping when cardHeightMode is content.
• Constrain metadata tables to wrap/scroll long values without bleeding into neighbors.
• Bump form-data (and hasown) versions and add a patch changeset.
Diagram

graph TD
A["WorkflowInstancePageContent"] --> B{"cardHeightMode"} --> C["MUI Grid (fixed)"] --> D["Cards: Details/Result/Inputs/Progress"]
B --> E["CSS Grid (content)"] --> D --> F["WorkflowInputs"] --> G["Metadata table wrapper"]
D --> H["WorkflowResult"] --> G
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Stay on MUI Grid/Stack for content mode
  • ➕ More consistent with existing MUI layout patterns
  • ➕ Potentially fewer custom CSS rules to maintain
  • ➖ Harder to guarantee equal-width columns with long, non-wrapping table content
  • ➖ Often still requires explicit minWidth/overflow fixes; overlap risk remains
2. Use MUI TableContainer / component-level table APIs
  • ➕ More semantically aligned with table overflow handling
  • ➕ May reduce the need for nested CSS selectors (e.g., '& table', '& td')
  • ➖ May require deeper changes to Backstage StructuredMetadataTable rendering
  • ➖ Less flexible if both Inputs and Result need consistent constraints across card types

Recommendation: The chosen approach (CSS-grid 2-column layout in content mode plus explicit table overflow/wrapping constraints) is the most direct and robust fix for long metadata content. It addresses the root cause (cards not being able to shrink below intrinsic table widths) while keeping changes localized to the affected workflow instance components.

Files changed (6) +110 / -39

Bug fix (4) +92 / -26
WorkflowInputs.tsxWrap inputs metadata table with overflow-safe styling +22/-1

Wrap inputs metadata table with overflow-safe styling

• Adds 'tss-react' styles to constrain metadata table width and enable horizontal scrolling when needed. Forces fixed table layout and cell word-wrapping to prevent long values from expanding the card beyond its column.

workspaces/orchestrator/plugins/orchestrator/src/components/WorkflowInstancePage/WorkflowInputs.tsx

WorkflowInstancePageContent.tsxUse CSS grid layout for content-mode cards and tighten overflow handling +53/-24

Use CSS grid layout for content-mode cards and tighten overflow handling

• Introduces content-mode specific classes to ensure cards can shrink (minWidth: 0) and to apply overflow/wrapping constraints. Replaces the previous nested Grid column layout in content mode with a two-column CSS grid ('minmax(0, 1fr)') using MUI Box to prevent card bleed/overlap.

workspaces/orchestrator/plugins/orchestrator/src/components/WorkflowInstancePage/WorkflowInstancePageContent.tsx

WorkflowResult.tsxConstrain result values table to avoid cross-card overflow +11/-0

Constrain result values table to avoid cross-card overflow

• Adds min/max width constraints and horizontal overflow handling for the result values region. Applies fixed table layout and word wrapping for table cells to keep long outputs contained within the card.

workspaces/orchestrator/plugins/orchestrator/src/components/WorkflowInstancePage/WorkflowResult.tsx

WorkflowRunDetails.tsxAllow run details grid to shrink within constrained columns +6/-1

Allow run details grid to shrink within constrained columns

• Adds 'sx={{ minWidth: 0 }}' to the Grid container to prevent intrinsic content from forcing wider layouts. Helps the details card respect the new content-mode sizing constraints.

workspaces/orchestrator/plugins/orchestrator/src/components/WorkflowInstancePage/WorkflowRunDetails.tsx

Other (2) +18 / -13
fix-workflow-instance-content-layout.mdAdd patch changeset for workflow instance layout fix +5/-0

Add patch changeset for workflow instance layout fix

• Introduces a changeset marking a patch release for the orchestrator plugin. Documents the fix for card overlap when 'cardHeightMode' is set to 'content'.

workspaces/orchestrator/.changeset/fix-workflow-instance-content-layout.md

yarn.lockBump form-data and hasown dependency versions +13/-13

Bump form-data and hasown dependency versions

• Updates 'form-data' to 2.5.6 and 4.0.6 (with corresponding checksum changes) and bumps 'hasown' to 2.0.4 in the orchestrator workspace lockfile. Keeps transitive dependencies aligned with the updated packages.

workspaces/orchestrator/yarn.lock

@sonarqubecloud

Copy link
Copy Markdown

@rhdh-qodo-merge

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

To customize comments, go to the Qodo configuration screen, or learn more in the docs.

Qodo Logo

@lokanandaprabhu
lokanandaprabhu merged commit f3054a1 into workspace/orchestrator Jul 30, 2026
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants