enabled default github identity resolver - #121
Merged
Merged
Conversation
Comment on lines
+40
to
+48
| // resolver(_, ctx) { | ||
| // const userRef = 'user:default/guest'; // Must be a full entity reference | ||
| // return ctx.issueToken({ | ||
| // claims: { | ||
| // sub: userRef, // The user's own identity | ||
| // ent: [userRef], // A list of identities that the user claims ownership through | ||
| // }, | ||
| // }); | ||
| // }, |
Contributor
There was a problem hiding this comment.
Can delete the unused section
Contributor
|
LGTM |
christophe-f
self-requested a review
March 16, 2023 15:07
christophe-f
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
enabled default github identity resolver. This change worked for me. But it may need some conditional logic to coexist with other identity resolved. Basically one can assume that given how a user was authenticated, there is an identity resolved that applies better than others. And then perhaps have a default one (the one I commented out).
Not sure how to write that conditional logic. This is better tested only after #120 is merged and it needs that data to do the mapping.
Which issue(s) does this PR fix
PR acceptance criteria
Put an
xin the boxes that applyHow to test changes / Special notes to the reviewer