RHIDP-2128 [Test automation] Establish AKS nightly tests - #1472
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
The image is available at: |
|
/test all |
|
The image is available at: |
|
/test all |
|
The image is available at: |
|
/test all |
zdrapela
changed the title
|
The image is available at: |
1 similar comment
|
The image is available at: |
|
/test all |
|
The image is available at: |
|
/test all |
There was a problem hiding this comment.
I guess we are good with using existing value files for rbac and non-rbac. creating new value files will make things complex in future.
There was a problem hiding this comment.
The config for AKS is slightly different. We might use the same file, but we will have to change it through the Helm install. I agree that maintaining two value files is worse than one. It is not that much values so it can be possible to change the values through the Helm install for AKS and use just one values file (well, one for non-RBAC, one for RBAC).
There was a problem hiding this comment.
I added diff-values_showcase_AKS.yaml file instead and use the values_showcase.yaml as a base. Both of the files are applied by helm upgrade -i https://github.com/janus-idp/backstage-showcase/pull/1472/files#diff-4d6549ba4c59a94aab379c14838198870ef2e610c26348b6c58c6fbffedc479bR372
|
/test all |
|
The image is available at: |
1 similar comment
|
The image is available at: |
|
/test all |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
This reverts commit ef883d2.
|
The image is available at: |
|
The image is available at: |
This reverts commit 3c25521.
|
/retest |
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhashkhileri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The image is available at: |
…loper#1472) * Add showcase-aks to Playwright & filter tests * Define values.yaml for AKS * Update env_variables.sh * Add AKS deployment initiation * Add AKS cluster URL * Override cluster router base for AKS * AKS check and test + namespace * Add exceptions for apply_yaml_files for AKS * Add override to force run as AKS job * Local dev (REVERT) * Revert "Local dev (REVERT)" This reverts commit 21f921a9634993c0dff2f7d0ff3e70dc540bbc1b. * Bypass cluster TLS * Update secrets-rhdh-secrets.yaml * Comment out broken sed * Disable GitHub org integration * Update openshift-ci-tests.sh * Change scope to testMatch * Change where is analytics enabled * Use diff value file for AKS * Don't use pipelines operator on AKS * Add `az` and cluster start-stop * Update Dockerfile * Add approuting check and enable * Revert "Add override to force run as AKS job" This reverts commit 35e7319. * Replace bsCluster with env values * Uncomment sed * Avoid shorthand that fails locally * Cluster information from `az` * Add RBAC tests to AKS * Fix GH APP from vault * Use second GH app for auth AKS * Fix typo * Revert "Change where is analytics enabled" This reverts commit 879e3aa. * Merge value files with `yq` * Reapply "Add override to force run as AKS job" This reverts commit 9bd004991ff7bfc6f16874acbebd1a8335955523. * Fixes * Local * Fix rbac values * Revert "Local" This reverts commit 489914aeb60543a2fd78e8250838429e4462f53b. * Skip for AKS, because of strange `sed: -e expression #1, char 136: unterminated `s' command` * Skip broken RBAC test on AKS * Bullet proofing * Skip `droute` and broken test on AKS * Fix test name * Typo * Disable broken analytics test * Update openshift-ci-tests.sh * Disable `az` start and stop * Add Tekton pipelines * Fix * Update openshift-ci-tests.sh * Disable RBAC * Enable az start stop * Remove `JOB_NAME` override * Enable RBAC tests * Revert "Remove `JOB_NAME` override" This reverts commit 5f75435. * Reapply "Remove `JOB_NAME` override" This reverts commit 3f71d15. * Add showcase-aks to Playwright & filter tests * Define values.yaml for AKS * Update env_variables.sh * Add AKS deployment initiation * Add AKS cluster URL * Override cluster router base for AKS * AKS check and test + namespace * Add exceptions for apply_yaml_files for AKS * Add override to force run as AKS job * Local dev (REVERT) * Revert "Local dev (REVERT)" This reverts commit 21f921a9634993c0dff2f7d0ff3e70dc540bbc1b. * Bypass cluster TLS * Update secrets-rhdh-secrets.yaml * Comment out broken sed * Disable GitHub org integration * Update openshift-ci-tests.sh * Change scope to testMatch * Change where is analytics enabled * Use diff value file for AKS * Don't use pipelines operator on AKS * Add `az` and cluster start-stop * Update Dockerfile * Add approuting check and enable * Revert "Add override to force run as AKS job" This reverts commit 35e7319. * Replace bsCluster with env values * Uncomment sed * Avoid shorthand that fails locally * Cluster information from `az` * Add RBAC tests to AKS * Fix GH APP from vault * Use second GH app for auth AKS * Fix typo * Revert "Change where is analytics enabled" This reverts commit 879e3aa. * Merge value files with `yq` * Reapply "Add override to force run as AKS job" This reverts commit 9bd004991ff7bfc6f16874acbebd1a8335955523. * Fixes * Local * Fix rbac values * Revert "Local" This reverts commit 489914aeb60543a2fd78e8250838429e4462f53b. * Skip for AKS, because of strange `sed: -e expression #1, char 136: unterminated `s' command` * Skip broken RBAC test on AKS * Bullet proofing * Skip `droute` and broken test on AKS * Fix test name * Typo * Disable broken analytics test * Update openshift-ci-tests.sh * Disable `az` start and stop * Add Tekton pipelines * Fix * Update openshift-ci-tests.sh * Disable RBAC * Enable az start stop * Remove `JOB_NAME` override * Enable RBAC tests * Revert "Remove `JOB_NAME` override" This reverts commit 5f75435. * Reapply "Remove `JOB_NAME` override" This reverts commit 3f71d15. * Better merging of base and diff value files * Fix indentation of value files * Switch from testMatch to testIgnore for AKS * Add test ignore * Update playwright.config.ts * Revert "Reapply "Remove `JOB_NAME` override"" This reverts commit ef883d2. * Increase timeout * Reapply "Reapply "Remove `JOB_NAME` override"" This reverts commit 3c25521. * Move `az_*` to `utils.sh`
3 participants
Description
This PR is making it possible to test RHDH installation on AKS. E2E tests are limited to those that run immediately without further configuration of the cluster (skipped tests defined in:
e2e-tests/playwright.config.ts). GitHub would be working, but we reached the maximum number of callback URLs.To distinguish which configuration should be applied, the
if [[ "$JOB_NAME" == *aks* ]]condition is used in.ibm/pipelines/openshift-ci-tests.sh.It uses different value file for AKS instance:
.ibm/pipelines/value_files/values_showcase_AKS.yamlThis PR adds the Azure CLI to the Dockerfile. The AKS test uses it to start the cluster and then to stop it after the test finishes. The account for Azure CLI was established using https://github.com/adrianriobo/mapt/blob/fix-272/hacks/azure/azure_setup.sh
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer