upgrade GH plugin support to prod - #1589
Conversation
|
|
The image is available at: |
|
@kim-tsao: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nickboldt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
As Prod Experience has said this is OK, +1 to the change. |
|
/cherrypick 1.3.x |
|
/cherry-pick 1.3.x |
|
@nickboldt: new pull request created: #1591 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nickboldt: new pull request could not be created: failed to create pull request against #1.3.x from head openshift-cherrypick-robot:cherry-pick-1589-to-1.3.x: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between janus-idp:1.3.x and openshift-cherrypick-robot:cherry-pick-1589-to-1.3.x"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |



Description
Please explain the changes you made here.
We have doc'd and tested these two plugins so we can declare their support level as prod
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer