Skip to content

upgrade GH plugin support to prod - #1589

Merged
nickboldt merged 1 commit into
redhat-developer:mainfrom
kim-tsao:update_to_prod
Sep 11, 2024
Merged

upgrade GH plugin support to prod#1589
nickboldt merged 1 commit into
redhat-developer:mainfrom
kim-tsao:update_to_prod

Conversation

@kim-tsao

Copy link
Copy Markdown
Member

Description

Please explain the changes you made here.
We have doc'd and tested these two plugins so we can declare their support level as prod

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@kim-tsao
kim-tsao requested a review from a team as a code owner September 11, 2024 15:32
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1589!

@openshift-ci

openshift-ci Bot commented Sep 11, 2024

Copy link
Copy Markdown

@kim-tsao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 813c589 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci

openshift-ci Bot commented Sep 11, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt

Copy link
Copy Markdown
Member

As Prod Experience has said this is OK, +1 to the change.

@nickboldt
nickboldt merged commit c0d9d07 into redhat-developer:main Sep 11, 2024
@nickboldt

Copy link
Copy Markdown
Member

/cherrypick 1.3.x

@nickboldt

Copy link
Copy Markdown
Member

/cherry-pick 1.3.x

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@nickboldt: new pull request created: #1591

Details

In response to this:

/cherrypick 1.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@nickboldt: new pull request could not be created: failed to create pull request against #1.3.x from head openshift-cherrypick-robot:cherry-pick-1589-to-1.3.x: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between janus-idp:1.3.x and openshift-cherrypick-robot:cherry-pick-1589-to-1.3.x"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherry-pick 1.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chadcrum pushed a commit to chadcrum/rhdh that referenced this pull request Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants