Skip to content

[release-1.6] chore(e2e): introduce e2e tests for RBAC Auditor log - #2760

Merged
openshift-merge-bot[bot] merged 3 commits into
redhat-developer:release-1.6from
dzemanov:RHIDP-6618-e2e-auditor-release-1.6
Jun 24, 2025
Merged

[release-1.6] chore(e2e): introduce e2e tests for RBAC Auditor log#2760
openshift-merge-bot[bot] merged 3 commits into
redhat-developer:release-1.6from
dzemanov:RHIDP-6618-e2e-auditor-release-1.6

Conversation

@dzemanov

@dzemanov dzemanov commented Apr 14, 2025

Copy link
Copy Markdown
Member

Description

This is a manual cherry pick for the new tests of Auditor service in RBAC plugin.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci
openshift-ci Bot requested review from josephca and psrna April 14, 2025 08:53
@dzemanov dzemanov changed the title chore(e2e): introduce e2e tests for RBAC Auditor log [release-1.6] chore(e2e): introduce e2e tests for RBAC Auditor log Apr 14, 2025
@github-actions

github-actions Bot commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

ciiay
ciiay approved these changes Apr 14, 2025
View reviewed changes

@ciiay ciiay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Verified the build on a cluster that the RBAC plugin works as expected.

@openshift-ci openshift-ci Bot added the lgtm label Apr 14, 2025
@christoph-jerolimov

christoph-jerolimov commented Apr 15, 2025

Copy link
Copy Markdown
Member

/retest

@ciiay

ciiay commented Apr 15, 2025

Copy link
Copy Markdown
Member

/test e2e-tests

7 similar comments
@ciiay

ciiay commented Apr 15, 2025

Copy link
Copy Markdown
Member

/test e2e-tests

@ciiay

ciiay commented Apr 15, 2025

Copy link
Copy Markdown
Member

/test e2e-tests

@ciiay

ciiay commented Apr 16, 2025

Copy link
Copy Markdown
Member

/test e2e-tests

@ciiay

ciiay commented Apr 16, 2025

Copy link
Copy Markdown
Member

/test e2e-tests

@AndrienkoAleksandr

AndrienkoAleksandr commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

/test e2e-tests

@ciiay

ciiay commented Apr 17, 2025

Copy link
Copy Markdown
Member

/test e2e-tests

@ciiay

ciiay commented Apr 23, 2025

Copy link
Copy Markdown
Member

/test e2e-tests

@PatAKnight

PatAKnight commented Apr 25, 2025

Copy link
Copy Markdown
Member

/hold

@AndrienkoAleksandr

AndrienkoAleksandr commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

/retest

@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions Bot added the Stale label May 7, 2025
@github-actions

github-actions Bot commented May 15, 2025

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions Bot added the Stale label May 15, 2025
@dzemanov
dzemanov force-pushed the RHIDP-6618-e2e-auditor-release-1.6 branch from 2817ebb to 3900091 Compare May 20, 2025 13:56
@openshift-ci openshift-ci Bot removed the lgtm label May 20, 2025
@github-actions

github-actions Bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@github-actions

github-actions Bot commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions Bot added the Stale label Jun 3, 2025
@dzemanov
dzemanov force-pushed the RHIDP-6618-e2e-auditor-release-1.6 branch from 3900091 to 74f9b74 Compare June 4, 2025 08:02
@github-actions github-actions Bot removed the Stale label Jun 5, 2025
@dzemanov
dzemanov force-pushed the RHIDP-6618-e2e-auditor-release-1.6 branch from 74f9b74 to 3121ce9 Compare June 5, 2025 09:38
@github-actions

github-actions Bot commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@dzemanov

dzemanov commented Jun 5, 2025

Copy link
Copy Markdown
Member Author

/retest

@dzemanov
dzemanov force-pushed the RHIDP-6618-e2e-auditor-release-1.6 branch from 3121ce9 to e8fe352 Compare June 9, 2025 11:48
@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@dzemanov
dzemanov force-pushed the RHIDP-6618-e2e-auditor-release-1.6 branch from 1d8259b to 28771ad Compare June 9, 2025 14:31
@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@github-actions

github-actions Bot commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@github-actions

github-actions Bot commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions Bot added the Stale label Jun 20, 2025
dzemanov added 3 commits June 23, 2025 19:06
@dzemanov
Enhance audit log validation in Playwright tests by adding log method…
ecb5a3e 
… and refactoring log utilities

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

RHIDP-6618 Rename scaffold.spec.ts to auditor-catalog.spec.ts and update test description for clarity

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

Refactor RBAC policy update call for improved readability

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

RHIDP-6618 Refactor RBAC API references in tests to use RBAC_API constants

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

RHIDP-6618 - Add shared utilities for RBAC audit-log Playwright tests

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

RHIDP-6618 Update scaffold tests: refine event log validation and improve test descriptions

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

test

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

RHIDP-6618 Refactor RBAC tests for improved structure and readability

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

Increase tail number

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Remove testing lines

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Make permission-evaluation more concrete

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Enable more precise filtering

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Fix policy-read by-query

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Switch to json logs

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Filter the logs more precisely

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Update pod selector

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Enable change of namespace

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Test pod logs

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Catch the logs

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Test

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>

Introduce rbac auditor tests

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
@dzemanov
Avoid ***** in logs
f95abfb 
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
@dzemanov
Fix policy endpoints
0ea4fd0 
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
@dzemanov
dzemanov force-pushed the RHIDP-6618-e2e-auditor-release-1.6 branch from 6e4ce56 to 0ea4fd0 Compare June 23, 2025 17:06
@github-actions

github-actions Bot commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@github-actions github-actions Bot removed the Stale label Jun 24, 2025
@dzemanov

dzemanov commented Jun 24, 2025

Copy link
Copy Markdown
Member Author

/retest

PatAKnight
PatAKnight approved these changes Jun 24, 2025
View reviewed changes

@PatAKnight PatAKnight left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@openshift-ci openshift-ci Bot added the lgtm label Jun 24, 2025
@openshift-ci

openshift-ci Bot commented Jun 24, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciiay, PatAKnight

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit a1e4531 into redhat-developer:release-1.6 Jun 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PatAKnight PatAKnight PatAKnight approved these changes
@josephca josephca Awaiting requested review from josephca
@psrna psrna Awaiting requested review from psrna
+1 more reviewer
@ciiay ciiay ciiay approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ciiay ciiay

@PatAKnight PatAKnight

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dzemanov @christoph-jerolimov @ciiay @AndrienkoAleksandr @PatAKnight @openshift-merge-robot