chore(config): add orchestrator plugin to dynamic-plugins.default.yaml - #3016
Conversation
|
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds three Orchestrator plugin packages to the default dynamic plugins configuration, enabling frontend and backend orchestration capabilities.
- Introduces a new “Orchestrator” group header in the YAML
- Adds the frontend Orchestrator plugin entry
- Adds two backend Orchestrator plugin entries (one for core orchestrator backend, one for the scaffolder module)
Comments suppressed due to low confidence (3)
dynamic-plugins.default.yaml:1090
- There are no accompanying unit or E2E tests for the new Orchestrator plugin configuration; consider adding tests to ensure the plugin loads and routes correctly.
- package: "@redhat/backstage-plugin-orchestrator@1.5.1"
dynamic-plugins.default.yaml:1109
- [nitpick] Add a comment explaining why this backend plugin is disabled by default to help future maintainers understand the intent.
disabled: true
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
rm3l
left a comment
rm3l
left a comment
There was a problem hiding this comment.
/lgtm
/hold
/cc @nickboldt
@nickboldt Any concerns if we merge this (to unblock https://issues.redhat.com/browse/RHIDP-7919)?
There is a thread related to this..
I've tested it (also upgrading from RHDH 1.6 to the image from this PR), and I didn't notice any impacts as long as these plugins are disabled by default.
nickboldt
left a comment
nickboldt
left a comment
There was a problem hiding this comment.
Since we're adding refs to 3rd party npmjs.com my only concern is that we don't control the build/release process for these plugins and they could get corrupted at the 3rd party hosting service.
However as long as @kim-tsao signs off on this risk, I'm OK with it from a build perspective.
I also like that you're ONLY testing LOCAL packages embedded in the container
nickboldt
left a comment
nickboldt
left a comment
There was a problem hiding this comment.
With https://github.com/redhat-developer/rhdh-operator/pull/1297/files#diff-5117fcae3688b1298446af33ab479b0c8504a65de1f8f634422209c1f9f2df5c merged to ensure that these plugins come from npm.registry.redhat.com when doing ioperator installs
and https://github.com/redhat-developer/rhdh-chart/blob/main/charts/backstage/templates/dynamic-plugins-configmap.yaml#L35 for chart installs
I'm +1 for this.
Obviously these plugins are not built with the Official Red Hat Way, using Konflux... nor are they published to RHEC... but at least they're using RH processes to land them on a RH registry, so this seems safe enough.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nickboldt, rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The image is available at: |
|
/retest |
6e67067
into
redhat-developer:main
redhat-developer#3016) * add orchestrator plugin to dynamic-plugins.default.yaml * fix * add dependencies * remove dependencies * fix disabled * add redhat registry to .npmrc * external plugins --------- Co-authored-by: Nick Boldt <nboldt@redhat.com>
redhat-developer#3016) * add orchestrator plugin to dynamic-plugins.default.yaml * fix * add dependencies * remove dependencies * fix disabled * add redhat registry to .npmrc * external plugins --------- Co-authored-by: Nick Boldt <nboldt@redhat.com>
Description
Added orchestrator plugins packages to dynamic-plugins.default.yaml
Which issue(s) does this PR fix
https://issues.redhat.com/browse/RHIDP-7885
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer