Skip to content

chore: fix issues with rbac deployment with orchestrator - #3213

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
y-first:add-orchestrator-to-rbac-deployment
Sep 9, 2025
Merged

chore: fix issues with rbac deployment with orchestrator#3213
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
y-first:add-orchestrator-to-rbac-deployment

Conversation

@y-first

@y-first y-first commented Jul 28, 2025

Copy link
Copy Markdown
Member

Description

Original PR with RBAC had missing or incorrect parameters in the values.yaml file.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci

openshift-ci Bot commented Jul 28, 2025

Copy link
Copy Markdown

Hi @y-first. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions

github-actions Bot commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from 929af20 to e7d6c06 Compare July 30, 2025 09:43
@github-actions

github-actions Bot commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from e7d6c06 to 6a2d092 Compare August 3, 2025 11:20
@github-actions

github-actions Bot commented Aug 3, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@subhashkhileri

subhashkhileri commented Aug 4, 2025

Copy link
Copy Markdown
Member

/ok-to-test

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch 3 times, most recently from 474c645 to 316f5fd Compare August 4, 2025 09:47
@y-first

y-first commented Aug 4, 2025

Copy link
Copy Markdown
Member Author

/test e2e-tests

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from 316f5fd to 643bf17 Compare August 4, 2025 11:01
@y-first

y-first commented Aug 4, 2025

Copy link
Copy Markdown
Member Author

/test e2e-tests

@y-first

y-first commented Aug 4, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from 643bf17 to d9353ff Compare August 4, 2025 12:04
@y-first

y-first commented Aug 4, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from d9353ff to c87fa3f Compare August 4, 2025 13:03
@y-first

y-first commented Aug 4, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from c87fa3f to df061be Compare August 4, 2025 13:46
@y-first

y-first commented Aug 4, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from df061be to fd318b6 Compare August 4, 2025 14:23
@y-first

y-first commented Aug 4, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from fd318b6 to 75c44d6 Compare August 4, 2025 14:50
@y-first

y-first commented Aug 4, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from 75c44d6 to 9f565fd Compare August 4, 2025 19:21
@y-first

y-first commented Aug 4, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from 468834c to db3d722 Compare September 2, 2025 19:41
@y-first

y-first commented Sep 2, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from db3d722 to e7568d5 Compare September 2, 2025 20:32
@y-first

y-first commented Sep 2, 2025

Copy link
Copy Markdown
Member Author

/retest

@github-actions github-actions Bot removed the Stale label Sep 3, 2025
@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from e7568d5 to a241c79 Compare September 5, 2025 01:42
@github-actions

github-actions Bot commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from a241c79 to bfd8006 Compare September 5, 2025 16:43
@y-first
y-first force-pushed the add-orchestrator-to-rbac-deployment branch from bfd8006 to 390393f Compare September 5, 2025 16:56
@y-first

y-first commented Sep 5, 2025

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@y-first

y-first commented Sep 5, 2025

Copy link
Copy Markdown
Member Author

/retest

@github-actions

github-actions Bot commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@y-first

y-first commented Sep 5, 2025

Copy link
Copy Markdown
Member Author

/retest

3 similar comments
@y-first

y-first commented Sep 5, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first

y-first commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first

y-first commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first

y-first commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

/retest-required

@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@y-first

y-first commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

/retest

2 similar comments
@y-first

y-first commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

/retest

@y-first

y-first commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

/retest

@gustavolira

gustavolira commented Sep 8, 2025

Copy link
Copy Markdown
Member

/LGTM

@openshift-ci

openshift-ci Bot commented Sep 8, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavolira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhdh-qodo-merge rhdh-qodo-merge Bot mentioned this pull request Apr 21, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albarbaro albarbaro Awaiting requested review from albarbaro
1 more reviewer
@gustavolira gustavolira gustavolira approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gustavolira gustavolira

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@y-first @subhashkhileri @gustavolira