Skip to content

test(e2e): flpath-2284 - Add orchestrator workflow tests, enhance notifications testing - #3248

Closed
testetson22 wants to merge 14 commits into
redhat-developer:mainfrom
testetson22:FLPATH-2284-ts
Closed

test(e2e): flpath-2284 - Add orchestrator workflow tests, enhance notifications testing#3248
testetson22 wants to merge 14 commits into
redhat-developer:mainfrom
testetson22:FLPATH-2284-ts

Conversation

@testetson22

@testetson22 testetson22 commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Description

  • Added Greeting Orchestrator workflow tests
  • Enhanced Notification tests and coverage
    This will provide the remainder of recommended tests for RHDH Notifications and Orchestrator and close out FLPATH-2284

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Test using PR RHDH CI pipeline. I've ran the tests against a Eco-eng Flightpath environment and may need to see what shakes out in RHDH CI in case we missed some Orchestrator config, but the tests are stable as far as I've been able to validate in my environment.

There is also an open issue with the Helm chart and a fix waiting for review that may affect Orchestrator workflow execution (See: FLPATH-2543. I have validated a workaround in my test environment with the tests.

@openshift-ci

openshift-ci Bot commented Jul 31, 2025

Copy link
Copy Markdown

Hi @testetson22. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@testetson22 testetson22 changed the title test(e2e): FLPATH-2284 - Add orchestrator workflow tests, enhance notifications testing test(e2e): flpath-2284 - Add orchestrator workflow tests, enhance notifications testing Jul 31, 2025
@github-actions

Copy link
Copy Markdown
Contributor

@testetson22

Copy link
Copy Markdown
Contributor Author

@subhashkhileri @gustavolira can I get /ok-to-test for this? I'd like to see if anything shakes out of the tests aside from the OSL version issue mentioned in the description. cc: @chadcrum

@subhashkhileri

Copy link
Copy Markdown
Member

/ok-to-test

@testetson22

Copy link
Copy Markdown
Contributor Author

/test e2e-tests

@openshift-ci

openshift-ci Bot commented Aug 7, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gustavolira for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions Bot added Stale and removed Stale labels Aug 20, 2025
@github-actions

github-actions Bot commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions

github-actions Bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@testetson22

Copy link
Copy Markdown
Contributor Author

/retest

@github-actions

Copy link
Copy Markdown
Contributor

@testetson22

Copy link
Copy Markdown
Contributor Author

/retest

@testetson22

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@testetson22

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Sep 11, 2025

Copy link
Copy Markdown

@testetson22: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests abddebd link true /test e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants